docs(distribution): describe multi-binary identity manifests - #74
Conversation
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: dcdbbf8
Approved with 1 non-blocking suggestion below. Address at your discretion.
Summary
| Reviewer | Findings |
|---|---|
| documentation:docs-reviewer | 1 |
documentation:docs-reviewer (1 findings)
💡 Suggestion - docs/distribution.md:434
The example tag scheme value
version_scheme: major_minor_run_patchreads oddly ("run" between minor and patch). If this isn't an actual accepted value in the identity manifest schema, it's a typo that readers may copy verbatim into their ownpackaging/identity.yml. Worth double-checking against the schema/identity-check validator before merge.
Completed in 60s | $1.03 | sonnet | daemon 0.2.142 | Glorfindel
| Field | Value |
|---|---|
| Model | sonnet |
| Reviewers | hybrid-synthesis, documentation:docs-reviewer, harness-engineering:harness-architecture-reviewer, harness-engineering:harness-enforcement-reviewer, harness-engineering:harness-knowledge-reviewer |
| Engine | claude · sonnet |
| Reviewed by | pr-review-daemon · monit-pr-reviewer |
| Duration | 60s wall · 56s compute (Reviewers: 41s · Synthesis: 15s) |
| Cost | $1.03 (estimated) |
| Tokens | 277.3k in / 7.8k out |
| Turns | 10 |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost |
|---|---|---|---|---|---|---|
| hybrid-synthesis | sonnet | 55.6k | 850 | 26.4k | 29.2k (1h) | $0.20 |
| documentation:docs-reviewer | sonnet | 55.3k | 3.0k | 26.4k | 28.8k (1h) | $0.23 |
| harness-engineering:harness-architecture-reviewer | sonnet | 54.2k | 388 | 26.4k | 27.8k (1h) | $0.18 |
| harness-engineering:harness-enforcement-reviewer | sonnet | 55.9k | 1.5k | 26.4k | 29.4k (1h) | $0.21 |
| harness-engineering:harness-knowledge-reviewer | sonnet | 56.3k | 2.0k | 26.4k | 29.9k (1h) | $0.22 |
Re-reviews only run when @monit-reviewer is re-requested as a reviewer — push as many commits as you need, then re-request when ready. PRs targeting branches other than main, master are skipped, even when @monit-reviewer is re-requested.
| a single manifest with `binaries:` instead of `binary:`. `repo`, `goreleaser_config`, | ||
| `version_file` and `tag` stay top-level; everything that is per-binary | ||
| (`archives`, `packages`, `keychain_probe`) moves under each entry: | ||
|
|
There was a problem hiding this comment.
🔵 Low (documentation:docs-reviewer): The example tag scheme value version_scheme: major_minor_run_patch reads oddly ("run" between minor and patch). If this isn't an actual accepted value in the identity manifest schema, it's a typo that readers may copy verbatim into their own packaging/identity.yml. Worth double-checking against the schema/identity-check validator before merge.
Reply to this thread when addressed.
There was a problem hiding this comment.
It is a real value: identity-check exports tag.version_scheme verbatim and §8.1 documents major_minor_run_patch (version.txt = MAJOR.MINOR, patch = workflow run number).
2 participants
Adds §8.4 for repos that ship several binaries from one module, goreleaser config and tag stream via
binaries:inpackaging/identity.yml— the shape open-cli-collective/.github#41 introduced and google-cli is the first consumer of. Contrasts it with the §8.3 monorepo shape.