Conversation
The runtime resolvers (GetURL, GetEmail, GetDefaultProject) consult the shared ~/.config/atlassian-cli/config.yml, but the *WithSource diagnostics behind `jtk config show` skipped it. After `jtk init` writes the shared store, `config show` rendered url/email as empty "-" rows and printed the legacy per-tool path (which may not exist) as "Config file:" — a working configuration looked unconfigured. - GetURLWithSource / GetEmailWithSource / GetDefaultProjectWithSource now consult the shared store between env and the legacy file, matching runtime precedence (auth_method and cloud_id already did). - The Config file row names the file actually read: the shared store when it exists, else the legacy path. - Drop the help text documenting the old blind spot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
jtk config showskips the shared~/.config/atlassian-cli/config.ymlthat the runtime resolvers actually use. Afterjtk initwrites the shared store,config showrenders url/email/default_project as empty-rows and prints the legacy per-tool path (which may not even exist) asConfig file:. A fully working configuration looks unconfigured:while
jtk mesucceeds. The blind spot was documented in the command's help text, but as a diagnostic surface it misleads more than it explains — I hit it minutes after a successfuljtk init.Fix
GetURLWithSource,GetEmailWithSource,GetDefaultProjectWithSourcenow consult the shared store between env and the legacy file — the same precedence the runtime getters use (auth_methodandcloud_idalready did this viajtkSectionWithSource).Config file:row names the file actually read: the shared store when it exists on disk, else the legacy path.After
Tests
Two new tests: shared-store values surface with the shared source label and the path row names the shared file; shared beats legacy per field (url from shared, email falling through to legacy).
go test ./tools/jtk/...green,gofmtclean.