Skip to content

fix(release): hand the Windows channels final asset names #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rianjs merged 2 commits into from
Sep 3, 2026
Merged

fix(release): hand the Windows channels final asset names #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f20d5fd
fix(release): hand the Windows channels final asset names
rianjs Sep 3, 2026
1c91a0c
fix(release): say how to fix a missing snapshot version
rianjs Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,23 @@ jobs:
env:
CHOCOLATEY: ${{ steps.meta.outputs.chocolatey-base-matrix }}
WINGET: ${{ steps.meta.outputs.winget-base-matrix }}
VERSION: ${{ steps.meta.outputs.version }}
run: |
set -euo pipefail
# The snapshot build names its archives with the snapshot version
# (e.g. 1.2.1-SNAPSHOT-abc1234); the published release uses the final
# version, so rewrite that substring before handing names to the
# Windows channels.
snapshot_version="$(jq -r '.version' dist/metadata.json)"
[ -n "$snapshot_version" ] && [ "$snapshot_version" != null ] || { echo "::error::dist/metadata.json has no version; the snapshot goreleaser step above must write it (check GORELEASER_CURRENT_TAG and the goreleaser config)"; exit 1; }
enrich() {
printf '%s' "$1" | jq -c --slurpfile artifacts dist/artifacts.json '
printf '%s' "$1" | jq -c --slurpfile artifacts dist/artifacts.json --arg snap "$snapshot_version" --arg final "$VERSION" '
def owns($name):
(.extra.ID // "") == $name or
((.extra.Binaries // []) | index($name) != null);
def finalize: split($snap) | join($final);
def asset($name; $arch):
[$artifacts[0][] | select(.type == "Archive" and .goos == "windows" and .goarch == $arch and owns($name)) | .name]
[$artifacts[0][] | select(.type == "Archive" and .goos == "windows" and .goarch == $arch and owns($name)) | .name | finalize]
| if length == 1 then .[0] else error("expected exactly one windows/" + $arch + " archive for " + $name + "; got " + (length|tostring)) end;
map(. + {x64_asset: asset(.name; "amd64"), arm64_asset: asset(.name; "arm64")})'
}
Expand Down
Loading