fix(identity-check): casks select archives, not builds - #42
Merged
Merged
Conversation
GoReleaser casks consume archives, so a multi-binary cask's ids refer to archive ids. The validator attributed them through the build map and rejected every valid two-binary config. Resolve cask ownership through the archives it already attributed, and make the fixture mirror a real two-binary layout (darwin and unix-win builds per binary, archive ids).
monit-reviewer
approved these changes
Sep 3, 2026
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 168d2e1
Summary
No issues found. (1 info-level observations excluded)
Completed in 38s | $1.55 | sonnet | daemon 0.2.142 | Glorfindel
| Field | Value |
|---|---|
| Model | sonnet |
| Reviewers | hybrid-synthesis, database:database-reviewer, documentation:docs-reviewer, harness-engineering:harness-architecture-reviewer, harness-engineering:harness-enforcement-reviewer, harness-engineering:harness-knowledge-reviewer, harness-engineering:harness-self-documenting-code-reviewer, security:security-code-auditor |
| Engine | claude · sonnet |
| Reviewed by | pr-review-daemon · monit-pr-reviewer |
| Duration | 38s wall · 35s compute (Reviewers: 26s · Synthesis: 9s) |
| Cost | $1.55 (estimated) |
| Tokens | 442.2k in / 6.6k out |
| Turns | 16 |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost |
|---|---|---|---|---|---|---|
| hybrid-synthesis | sonnet | 54.1k | 496 | 26.4k | 27.6k (1h) | $0.18 |
| database:database-reviewer | sonnet | 55.1k | 170 | 26.4k | 28.6k (1h) | $0.18 |
| documentation:docs-reviewer | sonnet | 52.9k | 2.1k | 26.4k | 26.4k (1h) | $0.20 |
| harness-engineering:harness-architecture-reviewer | sonnet | 56.3k | 497 | 26.4k | 29.8k (1h) | $0.19 |
| harness-engineering:harness-enforcement-reviewer | sonnet | 57.5k | 1.2k | 26.4k | 31.1k (1h) | $0.21 |
| harness-engineering:harness-knowledge-reviewer | sonnet | 57.3k | 1.0k | 26.4k | 30.8k (1h) | $0.21 |
| harness-engineering:harness-self-documenting-code-reviewer | sonnet | 54.9k | 672 | 26.4k | 28.4k (1h) | $0.19 |
| security:security-code-auditor | sonnet | 54.3k | 483 | 26.4k | 27.8k (1h) | $0.18 |
Re-reviews only run when @monit-reviewer is re-requested as a reviewer — push as many commits as you need, then re-request when ready. PRs targeting branches other than main, master are skipped, even when @monit-reviewer is re-requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idsare archive ids. The validator resolved them through the build map and rejected every valid two-binary config (found while wiring up google-cli).google-clifixture mirrors a real two-binary layout: darwin and unix-win builds per binary, archives with ids, casks selecting archive ids.Test plan
pytest actions/identity-check/test_identity.pypasses.goreleaser.yamlvalidates with this change and fails without it