Conversation
The basic_leak_checker validation layer tracked zeEventCreate and the deprecated zexCounterBasedEventCreate2 extension for event create/destroy leak detection, but not the core zeEventCounterBasedCreate API added in spec v1.15. Applications migrating from the deprecated extension to the core API saw false-positive LEAK reports because zeEventDestroy calls were counted while the corresponding create calls were not. Add zeEventCounterBasedCreate to the tracked create/destroy set and implement its Epilogue hook to count successful calls. Fixes: oneapi-src#512 Fixes: LZL-2723 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
|
The scorecard CI job failed because of "Error: Docker pull failed with exit code 1". |
|
@Jemale Could you restart the scorecard CI job ? https://github.com/oneapi-src/level-zero/actions/runs/34830573084/job/103932683337?pr=513 |
|
I restarted it and it failed again, @rwmcguir it looks like there's an issue with the scorecard job. Can we merge without it until it is fixed? |
rwmcguir
left a comment
rwmcguir
left a comment
There was a problem hiding this comment.
I've confirmed these are hand written files, i.e. not part of the auto-gen so change looks good.
|
As for the Scorecard it is not critical to our code, uncertain why it's failing but this is not due to code quality. |
|
@rwmcguir Please include it in the next public release |
4 participants
The basic_leak_checker validation layer tracked zeEventCreate and the
deprecated zexCounterBasedEventCreate2 extension for event
create/destroy leak detection, but not the core zeEventCounterBasedCreate
API added in spec v1.15. Applications migrating from the deprecated
extension to the core API saw false-positive LEAK reports because
zeEventDestroy calls were counted while the corresponding create calls
were not.
Add zeEventCounterBasedCreate to the tracked create/destroy set and
implement its Epilogue hook to count successful calls.
Fixes: #512
Fixes: LZL-2723
Ref: intel/llvm#23154