feat: TokenStorage#24
Open
jaredperreault-okta wants to merge 2 commits intojp-react-native-sdkfrom
Open
Conversation
jaredperreault-okta
force-pushed
the
jp-rn-tokenstorage
branch
3 times, most recently
from
fb18b8d to
69b8d28
Compare
jaredperreault-okta
force-pushed
the
jp-rn-tokenstorage
branch
from
69b8d28 to
e6d588d
Compare
FeiChen-okta
reviewed
May 1, 2026
|
|
||
| import android.content.Context | ||
| import android.content.SharedPreferences | ||
| import androidx.security.crypto.EncryptedSharedPreferences |
There was a problem hiding this comment.
EncryptedSharedPreferences module is not supported anymore. It is using Google's tink library which has issues on various devices. We'll need to write our own by using the default encryption from the device to avoid all the bugs.
Contributor
Author
There was a problem hiding this comment.
Does it make sense to use SharedPreferences or SQLlite as the backing store for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes changes from #23
The relevant commit(s) to this PR is