Skip to content

whitespace fixes#72

Merged
larshp merged 9 commits into
mainfrom
hvam/sdfsd1707
Jul 17, 2026
Merged

whitespace fixes#72
larshp merged 9 commits into
mainfrom
hvam/sdfsd1707

Conversation

@larshp

@larshp larshp commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@larshp larshp changed the title wip whitespace fixes Jul 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR primarily normalizes whitespace/trailing spaces across ABAP sources and updates lint/tooling configuration for the zmjs ABAP JavaScript interpreter codebase. However, it also introduces a functional change in zcl_mjs_env->has and adds a new standalone report under scripts/.

Changes:

  • Whitespace cleanup in core interpreter and type implementations.
  • Tooling updates: abaplint rules enabled and abaplint dependency versions bumped.
  • Added a new scripts/zmjs_test262 report for running the Test262 bundle from SMW0.

Reviewed changes

Copilot reviewed 6 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/zcl_mjs.clas.abap Trailing whitespace/formatting cleanup in interpreter implementation.
src/zcl_mjs_tokenizer.clas.xml XML header line changed (now includes a BOM).
src/zcl_mjs_env.clas.abap has implementation changed (behavioral change: no slot_map check).
src/zcl_mjs_builtins.clas.xml XML header line changed (now includes a BOM).
src/types/zcl_mjs_string.clas.abap Trailing whitespace/formatting cleanup in string builtins.
src/types/zcl_mjs_arr_methods.clas.xml XML header line changed (now includes a BOM).
scripts/zmjs_test262.prog.abap New report to load/run ZMJS_TEST262.JS from SMW0 and print timing/output.
scripts/zmjs_benchmark.prog.abap Minor whitespace/formatting cleanup.
package.json Bumps @abaplint package versions.
package-lock.json Lockfile updates for bumped @abaplint packages.
abaplint.jsonc Enables additional abaplint rules (beyond whitespace-only changes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/zcl_mjs_env.clas.abap
Comment thread src/zcl_mjs_tokenizer.clas.xml
Comment thread src/zcl_mjs_builtins.clas.xml
Comment thread src/types/zcl_mjs_arr_methods.clas.xml
@larshp
larshp marked this pull request as ready for review July 17, 2026 10:14
@larshp
larshp merged commit 2bf0fb1 into main Jul 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants