whitespace fixes#72
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR primarily normalizes whitespace/trailing spaces across ABAP sources and updates lint/tooling configuration for the zmjs ABAP JavaScript interpreter codebase. However, it also introduces a functional change in zcl_mjs_env->has and adds a new standalone report under scripts/.
Changes:
- Whitespace cleanup in core interpreter and type implementations.
- Tooling updates: abaplint rules enabled and abaplint dependency versions bumped.
- Added a new
scripts/zmjs_test262report for running the Test262 bundle from SMW0.
Reviewed changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/zcl_mjs.clas.abap | Trailing whitespace/formatting cleanup in interpreter implementation. |
| src/zcl_mjs_tokenizer.clas.xml | XML header line changed (now includes a BOM). |
| src/zcl_mjs_env.clas.abap | has implementation changed (behavioral change: no slot_map check). |
| src/zcl_mjs_builtins.clas.xml | XML header line changed (now includes a BOM). |
| src/types/zcl_mjs_string.clas.abap | Trailing whitespace/formatting cleanup in string builtins. |
| src/types/zcl_mjs_arr_methods.clas.xml | XML header line changed (now includes a BOM). |
| scripts/zmjs_test262.prog.abap | New report to load/run ZMJS_TEST262.JS from SMW0 and print timing/output. |
| scripts/zmjs_benchmark.prog.abap | Minor whitespace/formatting cleanup. |
| package.json | Bumps @abaplint package versions. |
| package-lock.json | Lockfile updates for bumped @abaplint packages. |
| abaplint.jsonc | Enables additional abaplint rules (beyond whitespace-only changes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
larshp
marked this pull request as ready for review
July 17, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.