Real Estate Tutorial (raame) by raame-odoo · Pull Request #1248 · odoo/tutorials

raame-odoo · 2026-04-22T12:29:32Z

PR for the Real Estate Module Tutorial

robodoo · 2026-04-22T12:29:35Z

…nd access rights A new estate module was created. Property model was created as well and contains some fields. Access rights were added.

vandroogenbd

Not much to say, runbot is green... Keep going! 🚀

vandroogenbd · 2026-04-23T08:14:07Z

+    _description = "Properties of the estate"
+
+    name = fields.Char(required=True)


Good practice to separate attributes from fields 👍

vandroogenbd · 2026-04-23T08:14:29Z

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
+access_property_model,access_property_model,model_estate_property,base.group_user,1,1,1,1


It is good practice to add a trailing empty line to your files

https://stackoverflow.com/questions/2287967/why-is-it-recommended-to-have-empty-line-in-the-end-of-a-source-file

vandroogenbd · 2026-04-23T08:15:15Z

+{
+    'name': 'Real Estate',
+    'depends': [
+        'base'


It is good practice to end such lines with a ,. This way, if someone later adds a line, they don't have to add the coma so the line stays unchanged, this keeps the git history cleaner!

vandroogenbd · 2026-04-23T08:15:26Z

+        'security/ir.model.access.csv'
+    ],
+    'application': True,
+    'license': 'AGPL-3'


Same as above

vandroogenbd · 2026-04-23T08:17:06Z

Forgot to say, please add a description to the PR

Base users were able to unlink records although they're just plebs.

Added an xml file for actions. Also added the 3 levels of menu items and linked them to actions. Finally, some new fields were added like active and state. Some new attributes were added to new and existing fields.

List view, form view, and search with filter were added in this Chapter

Many2one fields and One2many fields were added to represent types, tags, and offers

Added computed fields, inverse methods, and onchange methods

Added action buttons

This commit is here to introduce the testing framework of Odoo. Try running the tests using `--test-tags :TestEstateProperty`. Doc: https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation The tests were made such that the first one should work but the second one should fail. Your job is to ensure both tests pass in the end. You should update the behaviour of the appropriate models. If you want, you can also add a small test of your own to get a feel for it.

Added constraint and changed behaviour to pass the tests

vandroogenbd

Don't hesitate to ask me if you have questions and if you don't, keep it up! 💪

vandroogenbd · 2026-04-29T10:53:46Z

+    garage = fields.Boolean()
+    garden = fields.Boolean()
+    garden_area = fields.Integer()
+    garden_orientation = fields.Selection(selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')])


I know we're not paid by line count, but it is sometimes worth using linebreaks for readability

Suggested change

garden_orientation = fields.Selection(selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')])

garden_orientation = fields.Selection(

selection=[

('north', 'North'),

('south', 'South'),

('east', 'East'),

('west', 'West'),

],

)

vandroogenbd · 2026-04-29T10:55:03Z

+    garden_area = fields.Integer()
+    garden_orientation = fields.Selection(selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')])
+    active = fields.Boolean(default=True)
+    state = fields.Selection(selection=[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')], required=True, copy=False, default='new')


Same here

Suggested change

state = fields.Selection(selection=[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')], required=True, copy=False, default='new')

state = fields.Selection(

selection=[

('new', 'New'),

('offer_received', 'Offer Received'),

('offer_accepted', 'Offer Accepted'),

('sold', 'Sold'),

('cancelled', 'Cancelled'),

],

required=True,

copy=False,

default='new',

)

vandroogenbd · 2026-04-29T10:56:04Z

+    garden_orientation = fields.Selection(selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')])
+    active = fields.Boolean(default=True)
+    state = fields.Selection(selection=[('new', 'New'), ('offer_received', 'Offer Received'), ('offer_accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')], required=True, copy=False, default='new')
+    property_type_id = fields.Many2one("estate.property.type", string="property Type")


When the variable name is that explicit, you don't have to specify a string 😉

vandroogenbd · 2026-04-29T10:56:47Z

+    _check_expected_price = models.Constraint(
+    'CHECK(expected_price > 0)',
+    'A property expected price must be strictly positive',
+    )


Indentation is off here

Suggested change

_check_expected_price = models.Constraint(

'CHECK(expected_price > 0)',

'A property expected price must be strictly positive',

)

_check_expected_price = models.Constraint(

'CHECK(expected_price > 0)',

'A property expected price must be strictly positive',

)

vandroogenbd · 2026-04-29T10:58:04Z

+    _check_expected_price = models.Constraint(
+    'CHECK(expected_price > 0)',
+    'A property expected price must be strictly positive',
+    )
+
+    _check_selling_price = models.Constraint(
+    'CHECK(selling_price >= 0)',
+    'A property selling price must be positive',
+    )


Constraints should be after computes (see doc)

vandroogenbd · 2026-04-29T11:17:38Z

+    <menuitem id="property_menu_root" name="Real Estate">
+        <menuitem id="property_first_level_menu" name="Advertisements">
+            <menuitem id="property_model_menu_action" action="property_model_action"/>
+        </menuitem>
+        <menuitem id="settings_first_level_menu" name="Settings">
+            <menuitem id="property_type_model_menu_action" action="property_type_model_action"/>
+            <menuitem id="property_tag_model_menu_action" action="property_tag_model_action"/>
+        </menuitem>
+    </menuitem>


There are specific guidelines for xml (see doc)

Suggested change

<menuitem id="property_menu_root" name="Real Estate">

<menuitem id="property_first_level_menu" name="Advertisements">

<menuitem id="property_model_menu_action" action="property_model_action"/>

</menuitem>

<menuitem id="settings_first_level_menu" name="Settings">

<menuitem id="property_type_model_menu_action" action="property_type_model_action"/>

<menuitem id="property_tag_model_menu_action" action="property_tag_model_action"/>

</menuitem>

</menuitem>

<menuitem id="estate_menu_root" name="Real Estate">

<menuitem id="estate_property_menu" name="Advertisements">

<menuitem id="estate_property_menu_action" action="estate_property_action"/>

</menuitem>

<menuitem id="estate_settings_menu" name="Settings">

<menuitem id="estate_property_type_menu_action" action="estate_property_type_action"/>

<menuitem id="estate_property_tag_menu_action" action="estate_property_tag_action"/>

</menuitem>

</menuitem>

The idea is to match model names.

vandroogenbd · 2026-04-29T11:19:05Z

+    <record id="property_model_action" model="ir.actions.act_window">
+        <field name="name">Properties</field>
+        <field name="res_model">estate.property</field>
+        <field name="view_mode">list,form</field>
+    </record>
+
+    <record id="property_type_model_action" model="ir.actions.act_window">
+        <field name="name">Property Types</field>
+        <field name="res_model">estate.property.type</field>
+        <field name="view_mode">list,form</field>
+    </record>
+
+    <record id="property_tag_model_action" model="ir.actions.act_window">
+        <field name="name">Property Tags</field>
+        <field name="res_model">estate.property.tag</field>
+        <field name="view_mode">list,form</field>
+    </record>


You will need to do some renaming here to match the changes from above

vandroogenbd · 2026-04-29T11:20:30Z

+        <field name="view_mode">list,form</field>
+    </record>
+
+     <record id="estate_property_view_list" model="ir.ui.view">


Naming for the model views is great! 👍

vandroogenbd · 2026-04-29T11:23:09Z

+     <record id="estate_property_offer_view_list" model="ir.ui.view">
+        <field name="name">estate.property.offer.list</field>
+        <field name="model">estate.property.offer</field>
+        <field name="arch" type="xml">
+            <list string="Offers">
+                <field name="price" width="400px"/>
+                <field name="partner_id" string="Buyer" width="100px"/>
+                <field name="validity" string="Validity (days)" width="100px"/>
+                <field name="date_deadline" string="Deadline" width="100px"/>
+                 <button name="accept_offer" type="object" icon="fa-check"/>
+                 <button name="action_refuse" type="object" icon="fa-times"/>
+                <field name="status" width="100px"/>
+            </list>
+        </field>
+    </record>


It would make more sense to group the views by model, eg all of the estate_property views first, then all of the estate_property_offer views.

You don't have to, but you could also split them into 2 separate files to make it even cleaner (although here it is okay to keep them in the same file as it isn't too long).

vandroogenbd · 2026-04-29T11:23:48Z

Why is this here? 👀

raame-odoo requested a review from vandroogenbd April 22, 2026 12:29

raame-odoo self-assigned this Apr 22, 2026

raame-odoo force-pushed the 19.0-tutorial-raame branch from 9f184e7 to 7371099 Compare April 22, 2026 13:06

[ADD] estate: Creating new estate module with estate property model a…

6a48a78

…nd access rights A new estate module was created. Property model was created as well and contains some fields. Access rights were added.

raame-odoo force-pushed the 19.0-tutorial-raame branch from 7371099 to 6a48a78 Compare April 22, 2026 13:17

raame-odoo changed the title ~~Chapter 1-4~~ Chapter 1-4 (raame) Apr 23, 2026

vandroogenbd reviewed Apr 23, 2026

View reviewed changes

[FIX] estate: remove unlink permission for base users

b02fdc0

Base users were able to unlink records although they're just plebs.

raame-odoo changed the title ~~Chapter 1-4 (raame)~~ Real Estate Tutorial (raame) Apr 23, 2026

[ADD] estate: Added actions, menues, and new fields

9d4d467

Added an xml file for actions. Also added the 3 levels of menu items and linked them to actions. Finally, some new fields were added like active and state. Some new attributes were added to new and existing fields.

raame-odoo force-pushed the 19.0-tutorial-raame branch from 0acc010 to 9d4d467 Compare April 23, 2026 11:39

raame-odoo added 2 commits April 24, 2026 11:26

[ADD] estate: Chapter 6

07e5a3b

List view, form view, and search with filter were added in this Chapter

[ADD] estate: Chapter 7

7876339

Many2one fields and One2many fields were added to represent types, tags, and offers

raame-odoo force-pushed the 19.0-tutorial-raame branch from 8570dc0 to 7876339 Compare April 27, 2026 07:54

[ADD] estate: Chapter 8

b5fe287

Added computed fields, inverse methods, and onchange methods

raame-odoo force-pushed the 19.0-tutorial-raame branch 2 times, most recently from 577213f to 23e6402 Compare April 28, 2026 08:40

[ADD] estate: Chapter 9

88c7d39

Added action buttons

raame-odoo force-pushed the 19.0-tutorial-raame branch from 23e6402 to 88c7d39 Compare April 28, 2026 12:43

vandroogenbd and others added 2 commits April 28, 2026 15:33

[ADD] estate: Chapter 10

d1ca42c

Added constraint and changed behaviour to pass the tests

raame-odoo force-pushed the 19.0-tutorial-raame branch from 53100c5 to d1ca42c Compare April 29, 2026 07:13

vandroogenbd reviewed Apr 29, 2026

View reviewed changes

		_description = "Properties of the estate"

		name = fields.Char(required=True)

		@@ -0,0 +1,2 @@
		id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
		access_property_model,access_property_model,model_estate_property,base.group_user,1,1,1,1 No newline at end of file

Conversation

raame-odoo commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Apr 22, 2026

Uh oh!

vandroogenbd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vandroogenbd commented Apr 23, 2026

Uh oh!

vandroogenbd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

raame-odoo commented Apr 22, 2026 •

edited

Loading