lugva - Technical Training#1240
Open
lugva-odoo wants to merge 2 commits intoodoo:19.0from
Open
Conversation
|
|
delcourtfl
requested changes
Apr 23, 2026
delcourtfl
left a comment
delcourtfl
left a comment
There was a problem hiding this comment.
Hello there ! Good work already, just a few comments.
delcourtfl
requested changes
Apr 24, 2026
delcourtfl
requested review from
vandroogenbd
and removed request for
vandroogenbd
lugva-odoo
force-pushed
the
19.0-real-estate-lugva
branch
2 times, most recently
from
e1d9ef9 to
09368e5
Compare
delcourtfl
reviewed
Apr 28, 2026
delcourtfl
left a comment
delcourtfl
left a comment
There was a problem hiding this comment.
Hello there ! Really good work, not much to say, you got the general idea for module development.
A test was added to your branch, if you have some extra time you can try to run/adapt it to ensure it works properly on your implementation.
Also to end this part in a clean way you should squash your commits (using an interactive rebase) into:
- one for estate module
- one for estate_account module
Added declaration of the estate module as a new installable application. More can be found in Chapter 2 of Server Framework 101
Finished chapter 1 for owl components, to get to know the basics of the framework. More can be found in Discover the web framework: Chapter 1.
lugva-odoo
force-pushed
the
19.0-real-estate-lugva
branch
from
bfe5d38 to
8001a22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.