First module created by covey-odoo · Pull Request #1234 · odoo/tutorials

covey-odoo · 2026-04-21T13:14:13Z

Creation of Estate Module:

Initial model created
Initial menu created

robodoo · 2026-04-21T13:14:17Z

…reated by/on and Last updated by/on as they are automatically generated.

delcourtfl

Hello there ! Good work already, just a few comments.

Also it seems your first commits have the wrong author set (most probably because your config was not properly set before pushing, might want to check into this as a general git exercise)

delcourtfl · 2026-04-22T08:00:10Z

@@ -0,0 +1,32 @@
+# -*- coding: utf-8 -*-


This line is not needed anymore

delcourtfl · 2026-04-22T08:02:21Z

+        string='Type',
+        selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')],
+        help="this is used to indicated the garden orientation"
+    )


It's recommended to have one empty line at the end of each file

delcourtfl · 2026-04-22T08:08:46Z

+    'author': "covey",
+    'website': "",
+    'category': 'Tutorials',
+    'version': '0.1',


Suggested change

'version': '0.1',

'version': '19.0.0.1.0',

First 2 numbers of the version are the odoo version, and the 3 next are your module's version. This will prevent your module to be installed in another version than 19.0 in this instance. (Standard modules don't do it because they are 19.0)

delcourtfl · 2026-04-22T08:13:09Z

+    'version': '0.1',
+    'application': True,
+    'installable': True,
+    'depends': ['base'],


Suggested change

'depends': ['base'],

'depends': [

'base',

],

Most of the time it's better to keep arrays formatted in a way that will limit further diff, and doesn't break the git blame when we need to add some additional dependencies

delcourtfl · 2026-04-22T08:18:20Z

+    'author': "covey",
+    'website': "",


Suggested change

'author': "covey",

'website': "",

'author': 'covey',

'website': '',

Try to avoid mixing single and double quote when it's not needed

delcourtfl

Hello ! Everything is quite good already, just added a few minor remarks.

delcourtfl · 2026-04-24T15:36:04Z

+            if float_is_zero(record.selling_price, precision_digits=2) or float_is_zero(
+                record.expected_price, precision_digits=2
+            ):
+                raise ValidationError(
+                    "Selling price and expected price must be greater than zero."
+                )
+            if (
+                float_compare(
+                    record.selling_price,
+                    record.expected_price * 0.9,
+                    precision_digits=2,
+                )
+                < 0
+            ):
+                raise ValidationError(
+                    "Selling price cannot be lower than 90%of expected price!"
+                )


This function is not that readable, I suppose it's what a linter would suggest to avoid too long lines (+80 char), but I think it can be improved in a few ways (avoid inconsistent line breaks, use temp variables, ...), for example:

Suggested change

if float_is_zero(record.selling_price, precision_digits=2) or float_is_zero(

record.expected_price, precision_digits=2

):

raise ValidationError(

"Selling price and expected price must be greater than zero."

)

if (

float_compare(

record.selling_price,

record.expected_price * 0.9,

precision_digits=2,

)

< 0

):

raise ValidationError(

"Selling price cannot be lower than 90%of expected price!"

)

if any(

float_is_zero(value, precision_digits=2)

for value in [record.selling_price, record.expected_price]

):

raise ValidationError(

"Selling price and expected price must be greater than zero."

)

if float_compare(

record.selling_price,

record.expected_price * 0.9,

precision_digits=2,

) < 0:

raise ValidationError(

"Selling price cannot be lower than 90% of expected price!"

)

delcourtfl · 2026-04-24T15:37:46Z

+    _check_offer_price_positive = models.Constraint(
+        "CHECK(price > 0)", "The offer price must be positive."
+    )


Always try to keep the constraints after the fields (see https://www.odoo.com/documentation/19.0/contributing/development/coding_guidelines.html#symbols-and-conventions for the model attribute order)

delcourtfl · 2026-04-24T15:40:51Z

+    "version": "19.0.0.1.0",
+    "application": True,
+    "installable": True,
+    "depends": ["base"],


Suggested change

"depends": ["base"],

"depends": [

"base",

],

This commit is here to introduce the testing framework of Odoo. Try running the tests using `--test-tags :TestEstateProperty`. Doc: https://www.odoo.com/documentation/18.0/developer/reference/backend/testing.html?highlight=tests#invocation The tests were made such that the first one should work but the second one should fail. Your job is to ensure both tests pass in the end. You should update the behaviour of the appropriate models. If you want, you can also add a small test of your own to get a feel for it.

delcourtfl

Good work, just a few formatting nitpicks.

Also to end this part in a clean way you should squash your commits (using an interactive rebase) into:

one for estate module
one for estate_account module

(And don't forget to check the runbot style CI 👀)

delcourtfl · 2026-04-29T17:31:22Z

+                record.garden_area = 0
+                record.garden_orientation = None
+
+    def cancel_sale(self):


Better to explicitly keep action in the name in this case (so that we know it's coming from the ui): action_cancel_sale

delcourtfl · 2026-04-29T17:31:41Z

+        for record in self:
+            record.state = "cancelled"
+
+    def mark_as_sold(self):


Same as above: action_mark_as_sold

delcourtfl · 2026-04-29T17:33:19Z

@@ -0,0 +1 @@
+from . import test_estate_property


covey-odoo marked this pull request as ready for review April 21, 2026 13:15

Mathilde411 requested a review from delcourtfl April 21, 2026 13:31

odoo added 2 commits April 22, 2026 09:46

[ADD] Estate module created; properties with fields created.

cdc624d

[ADD] Properties edited: name & expected price -> required. Removed c…

786ed2e

…reated by/on and Last updated by/on as they are automatically generated.

covey-odoo force-pushed the 19.0-covey-technical-training branch from 6c4f13f to fce6075 Compare April 22, 2026 07:47

covey-odoo added 2 commits April 22, 2026 10:04

[ADD] Added menu to app

5b823c4

[REM] Reformatting code for Ruff styling

64d81ad

covey-odoo force-pushed the 19.0-covey-technical-training branch from c98f6fa to 64d81ad Compare April 22, 2026 08:04

delcourtfl reviewed Apr 22, 2026

View reviewed changes

covey-odoo added 4 commits April 22, 2026 11:00

[ADD] Added active and state fields

ece53a2

[ADD] added Menu, basic views and filters

4d205a1

[ADD] Relations Between Models: Types, Tags, Offers

d231b12

[CLN] Added empty line at each eof

ab3a6b1

covey-odoo force-pushed the 19.0-covey-technical-training branch 2 times, most recently from 145cd42 to aa12051 Compare April 24, 2026 09:21

covey-odoo added 2 commits April 24, 2026 11:22

[ADD] Chapter 8: Computed Fields And Onchanges

8b0fb24

[ADD] Chapter 9: Ready For Some Action?

cfe6336

covey-odoo force-pushed the 19.0-covey-technical-training branch from aa12051 to cfe6336 Compare April 24, 2026 09:26

[ADD] Chapter 10: Constraints

f999c93

delcourtfl requested changes Apr 27, 2026

View reviewed changes

covey-odoo and others added 2 commits April 28, 2026 10:26

[ADD] Chapter 11: Add The Sprinkles

0b298fa

delcourtfl requested changes Apr 29, 2026

View reviewed changes

		@@ -0,0 +1 @@
		from . import test_estate_property No newline at end of file

Conversation

covey-odoo commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Apr 21, 2026

Uh oh!

delcourtfl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

delcourtfl left a comment

Choose a reason for hiding this comment

Uh oh!

delcourtfl Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

delcourtfl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

covey-odoo commented Apr 21, 2026 •

edited

Loading

delcourtfl Apr 24, 2026 •

edited

Loading

delcourtfl left a comment •

edited

Loading