Skip to content

test: set Content-Type in empty-array round-trip trace RBAC tests #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavolloffay merged 1 commit into from
Oct 22, 2026
Merged

test: set Content-Type in empty-array round-trip trace RBAC tests #942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/traces/v1/trace_rbac_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ func TestRBACSearchResult(t *testing.T) {
// a zero-result Tempo search response must round-trip through the JSON
// unmarshal/marshal cycle with "traces": [] intact, not silently dropped.
func TestSearchResponseEmptyTracesPreserved(t *testing.T) {
resp := &http.Response{Header: http.Header{}}
resp := &http.Response{Header: http.Header{HeaderContentType: []string{ContentTypeJSON}}}

searchResponse := &tempopb.SearchResponse{}
in := []byte(`{"traces":[]}`)
Expand All @@ -569,7 +569,7 @@ func TestSearchResponseEmptyTracesPreserved(t *testing.T) {
// bug (see the comment on unmarshal/marshal). Before this fix, unmarshal/
// marshal used github.com/golang/protobuf/jsonpb for this type too.
func TestTraceByIDResponseEmptyResourceSpansPreserved(t *testing.T) {
resp := &http.Response{Header: http.Header{}}
resp := &http.Response{Header: http.Header{HeaderContentType: []string{ContentTypeJSON}}}

traceByIDResponse := &tempopb.TraceByIDResponse{}
in := []byte(`{"trace":{"resourceSpans":[]}}`)
Expand Down
Loading