Repository navigation
Conversation
GetSourceScreenshot calls Utils::ImageFormat::MimeType() since "utils: Move the screenshot MIME type into a helper" (obs-rust#6), but RequestHandler_Sources.cpp never includes ImageFormat.h and nothing it includes pulls it in, so the plugin no longer compiles in a build with the frontend and obs-websocket: "'Utils::ImageFormat' has not been declared". The standalone helper test and the obs-studio PR builds, which skip the full app, did not catch it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Friendly nudge on this one: obs-studio master now pins this fork at a commit where |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the build of the plugin in a full OBS build (frontend + obs-websocket), broken since #6.
GetSourceScreenshotcallsUtils::ImageFormat::MimeType()since "utils: Move the screenshot MIME type into a helper" (#6), butsrc/requesthandler/RequestHandler_Sources.cppnever includes../utils/ImageFormat.h, and nothing it includes pulls it in (RequestHandler.hincludes../utils/Obs.h, notUtils.h). A full build fails with:This adds the one missing include.
Motivation and Context
My mistake in #6: its test (
test_ws_image_mimein obs-rust/obs-studio#652) compiles the helper on its own, and the obs-studio PR builds skip the full app, so nothing compiled this file before #6 and #652 merged. obs-studio master now pins 3e46553 (#652), so the next full build there (the daily release gate) would fail until the pin moves past this fix.How Has This Been Tested?
ENABLE_RUST_LIBOBSOFF and ON).test_ws_image_mime,test_ws_filter_settings_event,test_ws_scene_count, and the Tier 4 GetStats phase).Types of changes
🤖 Generated with Claude Code