Repository navigation
ci: skip redundant exact-hit saves for native app caches - #1384
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #1286; extends merged #1381's Ubuntu exact-hit guard to measured native app cache lanes.
Windows, macOS and Flatpak compiler-cache consumers restored exact keys, then compressed the same stores before immutable-key reservation failures. Add restore IDs and exact-hit save predicates to those three app jobs. Existing event/branch/ccache-success conditions remain intact; misses and compatible fallback restores can publish new keys. Restore/build/test paths and cache writer policy do not change. No new workflow or Tier 2 recovery changes (#1362).
Actual evidence
Same-revision full consumer run 39090099191 passed. Existing-key save step durations:
These are individual avoided-work opportunities, not measured merge-queue speedups. The source revision differs after this change; no additional full workflow was dispatched just to verify the guards.
RED → GREEN
b8c414ca4: all three job cases fail due to missing restore IDs/exact-hit save guards.uv run -m unittest ci.test_native_cache_exact_hit ci.test_ubuntu_cache_preserve ci.test_ci_toml ci.test_ci_tests_stdlib_only ci.test_release_native_cachepasses all 16 tests. Covers matching restore/save keys, all existing guard conditions, Ubuntu fallback compatibility, declared families and standalone test compatibility.git diff --checkpasses. Local RED and separate GREEN pushed together under coordination policy.