Repository navigation
fix: coordinate CEF initialization, browser tasks and unload - #1
Merged
Merged
Conversation
zackees
added a commit
to obs-rust/obs-studio
that referenced
this pull request
Oct 18, 2026
Preserve the browser runtime and JavaScript bridge checks against both core variants. Use a disposable basic-store profile for isolated GUI validation; production credential storage is unchanged. Depends on obs-rust/obs-browser#1. Full platform and packaging conversion remains in progress.
zackees
marked this pull request as ready for review
October 18, 2026 04:40
chriscoveries
pushed a commit
to chriscoveries/obsrust-fork
that referenced
this pull request
Oct 18, 2026
* test(build): define shared native build and plugin contracts (RED) Refs obs-rust#1332. Both integration contracts fail because the shared-library backend is not implemented. Preserve the full application conversion and performance requirements in the build plan. * build: compile and dynamically link native targets with cc::Build (GREEN) Refs obs-rust#1332. Compile separate or unity C/C++ sources with cc::Build, link shared libraries with target-specific conventions and keep generated source paths explicit. Both native integration contracts and all-target clippy pass on Linux. Full libobs/application conversion remains in progress. * test(build): require the bundled obs-sys crate to build real libobs (RED) Refs obs-rust#1332. The bundled C API test fails at the explicitly unimplemented libobs backend. Move the existing source sets into a manifest shared with the CMake reference so the new native build does not maintain a divergent source list. * feat(build): compile bundled Linux libobs through cc::Build * test(build): require native C and Rust libobs twins * feat(build): reuse common objects for the Rust libobs twin * test(build): require real OBS filter and transition module loading * feat(build): compile and load OBS filter and transition modules * test(build): require the real native OpenGL renderer * feat(build): compile OpenGL and render frames with both libobs variants * test(build): require native executables linked to shared libraries * feat(build): link native executables and preserve static archive inputs * test(build): require x264, FFmpeg, and recording output modules * feat(build): build recording modules and validate H264 AAC output * test(build): require deployed FFmpeg mux helper and Matroska recording * feat(build): deploy and exercise FFmpeg recording helper * test(build): require image text capture audio and service modules * feat(build): build common source and service modules with cc * test(build): require native PipeWire module support * feat(build): compile and load PipeWire with native graphics initialized * test(build): require frontend API and Qt VST module * feat(build): compile frontend API and Qt VST with explicit moc generation * test(build): require separate C and C++ target flags * feat(build): isolate C and C++ compiler options for mixed targets * test(build): require Qt UI resources and real spinbox widgets * feat(build): generate Qt UI resources and compile shared widgets * test(build): require a Cargo-built OBS frontend executable * feat(build): compile and link the Linux OBS frontend through cc * test(build): require the real frontend GUI to start and close * test(build): run the staged OBS GUI with both native cores * test(build): require an actual frontend recording * test(build): validate recording through the real OBS frontend * test(build): require NVENC plugin twins and capability helper * feat(build): build and exercise NVENC plugin twins through cc * test(build): require NVENC in the staged GUI runtime * test(build): exercise NVENC through the staged OBS frontend * test(build): require the native OBS scripting graph * feat(build): compile Lua and Python scripting with native runtime checks * test(build): require the frontend Tools plugin graph * feat(build): compile frontend Tools and exercise saved GUI scripts * fix(build): normalize compiler paths and account for native test targets * test(build): require the native websocket plugin and real wire behavior * test(build): require Tier 2 to read canonical native source sets * fix(build): derive Tier 2 exclusions from the shared source manifest * feat(build): compile and exercise the native websocket server with cc * test(build): require individual compilation of explicit unity groups * test(ci): require uv before the Tier 2 manifest reader * fix(ci): install uv in the stock Tier 2 job containers * feat(build): compile libobs unity members as separate translation units * test(build): require native VLC playlist playback in the staged app * feat(build): compile VLC with optional runtime discovery and verify playback * test(build): require building the unchanged C tests through cc * feat(build): compile and run the native C test inventory with cc * test(build): require compiled PCH with language and invalidation parity * build: add optional compiled PCH to native Linux cores * test(obs-sys): require configurable bundled native build modes * build(obs-sys): configure bundled unity and PCH through Cargo * test(build): require native browser module and CEF helper artifacts * build: enable Linux CEF browser module and docks with cc::Build Preserve the browser runtime and JavaScript bridge checks against both core variants. Use a disposable basic-store profile for isolated GUI validation; production credential storage is unchanged. Depends on obs-rust/obs-browser#1. Full platform and packaging conversion remains in progress. * docs: record native build measurements with explicit job limits * docs: record unity on and PCH off as the selected default * docs: audit PCH requests and actual warm compiler execution * test: require optional FDK AAC build and actual encoded recordings * build: compile optional FDK AAC module through cc::Build * test: require optional JACK and sndio native modules * build: support JACK and sndio with real native audio capture checks * docs: record JACK and sndio staged GUI validation * test: require QSV native module and matching core capabilities * build: add Linux QSV graph with unity PCH and CMake runtime parity * test: require MP4 and MOV to honor disabled HEVC support * fix: preserve MP4 MOV and VAAPI builds with HEVC disabled * test: require the unchanged VLC compatibility suite in the Cargo graph * build: run unchanged VLC compatibility tests through Cargo * test: require graphics cmocka coverage in the Cargo graph * build: add unchanged graphics audio compatibility tests to Cargo * docs: record combined native graphics and VLC compatibility evidence * test: expose uninitialized sub-sample audio buffering intervals * fix: initialize audio interval before zero-tick buffering * test: require the audio interval regression in the Cargo battery * build: include the audio interval regression in the native Cargo battery * docs: record fixed-core application and audio compatibility validation * test: require the native WebRTC WHIP module and registrations * build: compile and stream the Linux WebRTC module through cc build * test: require the original standalone WHIP tests in the Cargo graph * build: compile the unchanged WHIP clock and host tests through Cargo * test: stage the native runner early and honor implicit GUI recording * docs: defer remaining parity validation to follow-up 1390 * docs: clarify libdatachannel SDK version in build report
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinated with obs-rust/obs-studio#1333. This dependency fix lands before the parent PR is merged; its production commit is already selected by the parent pin.
Change
Regression evidence
RED commits:
37bc20b(queue before initialization),722370d/a9a56fd(real module immediate unload and private source early release).Implementation:
0c3b700.Linux x86_64, CEF 7871 / Chromium 150:
CefTask_0_CToCpp called with invalid version -1; fixed rejects the task safely.The staged Cargo-built frontend with this module creates a custom browser dock, navigates a local panel page and receives its JavaScript readiness title. The separate blank browser-source investigation is resolved for the disposable Linux test profile, as described below. The production startup fix alone did not resolve that credential-service integration issue.
Remaining validation
Linux startup/shutdown and staged application validation are complete. Windows/macOS runtime, normal desktop keyring integration and packaged applications remain unverified and are deferred with the parent prototype follow-ups in obs-rust/obs-studio#1332. These focused tests do not prove absence of leaks. New tests are documented in
tests/README.md; existing tests and public OBS headers are unchanged.Follow-up runtime diagnosis
CEF net logging shows the isolated desktop session's global persistent-cookie key load never completing, while the custom panel's separate cookie store completes. In a fresh disposable profile,
--password-store=basiccompletes the global load and passes the unchanged browser-source green pixel andwindow.obsstudio.getCurrentScenecallback checks, WebSocket checks, real frontend H264/AAC recording, saved profile and normal shutdown. A second run with basic storage and no net logging also passes. Both runs use the final rebuilt module/helper with this startup fix. Production credential-storage behavior is unchanged. The parent now passes the complete staged Cargo GUI checks against both C and Rust cores, including actual native dock pixels, browser source rendering/JavaScript, helper processes, recordings and saved configuration. A warm run passes with 226 hits and zero misses; its 77.56 s interval includes runtime checks, not just compilation. Normal desktop keyring integration remains unverified.Real initialization-failure characterization
Test-only follow-up
4f26bdastarts a real module holding a fresh profile, then asecond module using the same locked profile. Shutdown is released only after
CEF reports actual initialization failure (exit code 24). Both original and
fixed modules unload successfully. This verifies preservation of the failure
contract; it is not another unique RED regression. The parent remains pinned
to production commit
0c3b700.Shipping validation
The maintainer requested landing the prototype and doing further validation afterward. Parent shipping head
26f33f149passes the actual staged OBS application against both C/Rust cores with this production browser commit: browser/source/dock pixels, JavaScript/websocket behavior, profile/frontend recording and normal shutdown. The final native invocation completes successfully in440.60s including compilation/runtime. Required browser clang-format check is green; the earlier focused RED/GREEN/lifecycle review remains applicable. This merge preserves the production commit referenced by the parent gitlink.