Conversation
…ffix `LtIncorrectUnlint` was already fixed to split the tail on ":" before checking membership, so `many-void-attributes:37` style suppressions of a real lint are accepted. That fix (from PR #1404, closing #1388) had a generic unit test, but no integration-level pack exercising the actual registered lint list the way the reported eo-runtime failure did. Add that pack so the exact regression cannot resurface unnoticed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011JuFSRNk5QvWp5dnwsqPyW
yegor256
marked this pull request as ready for review
September 10, 2026 06:28
zaguzovmaksim0-hue
approved these changes
Sep 10, 2026
zaguzovmaksim0-hue
left a comment
zaguzovmaksim0-hue
left a comment
There was a problem hiding this comment.
I checked the current implementation and the regression scope. LtIncorrectUnlint.nameOf() already strips the :line suffix before membership validation, and invalid() explicitly accepts both name:N and name:N-M, so the reported many-void-attributes:37 shape is valid on current master.
The value of this PR is therefore the production-pack regression: it uses the real registered lint name instead of a synthetic name and runs through the same pack machinery that originally exposed the problem. That is the right way to pin the now-correct behavior without changing implementation code.
All current CI checks are green across Linux, macOS, and Windows. No correctness issue found. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LtIncorrectUnlintreports "Suppressing ... does not make sense" for+unlint many-void-attributes:37-style suppressions of a real lint,because it looks up the lint name after stripping the
:linesuffix.Looking at
src/main/java/org/eolang/lints/LtIncorrectUnlint.javaonmaster, this is already correct:nameOf()splits the tail on:before checking membership in the known-lints set, and
LtIncorrectUnlintTest#understandsUnlintsWithLineNumberalready coversthe shape generically. That fix landed as a side effect of PR #1404
(closing #1388), which rewrote this class, but #1021 itself was never
closed and had no coverage using an actual registered lint name run
through the production pack pipeline (the exact way the originally
reported
eo-maven-plugin:lintfailure onwin32.eoexercised it).This PR adds that missing integration-level regression pack, using the
real
many-void-attributeslint name with a line suffix, assertingzero defects — so this exact scenario can never silently regress again.
Test plan
mvn test -Dtest=LtByXslTest,LtIncorrectUnlintTestpasses locally, including the new packpacks/single/incorrect-unlint/allows-real-lint-with-line-suffix.yamlCloses #1021
🤖 Generated with Claude Code
https://claude.ai/code/session_011JuFSRNk5QvWp5dnwsqPyW
Generated by Claude Code