Conversation
The merge script ran mvn without excluding the `proguard` profile or setting MAVEN_OPTS, so on JDK 21 (rultor's yegor256/java image) the profile activates and proguard-maven-plugin 2.7.0 fails to obfuscate without --add-opens. Align merge with the release script, which already works around this and skips obfuscation entirely since it only matters for the deployed artifact. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Aav9e7z6jdPsj47FrtbxJY
Member
Author
|
The This is a network error from zizmor's online Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1305.
Problem
Every
@rultor mergefails on rultor'syegor256/javaimage (JDK 21):The
proguardprofile inpom.xmlactivates on JDK[,22), so it's active on rultor's JDK 21 but not on a locally used JDK 23 — which is whymvn clean install -Pqulicepasses locally while the merge check fails. ProGuard 2.7.0 needs--add-opensto read JDK classes on JDK 21+, and obfuscation doesn't add anything to a merge check anyway — it only matters for the deployed artifact.The
releasescript already works around exactly this (exportsMAVEN_OPTSand passes!proguard), but themergescript did neither.Fix
Align the
mergescript in.rultor.ymlwith thereleasescript:Changes
.rultor.yml— exportMAVEN_OPTSand exclude theproguardprofile in themergescript.🤖 Generated with Claude Code
https://claude.ai/code/session_01Aav9e7z6jdPsj47FrtbxJY
Generated by Claude Code