Skip to content

fix(#1305): skip proguard obfuscation in rultor merge script - #1342

Draft
yegor256 wants to merge 1 commit into
masterfrom
1305
Draft

fix(#1305): skip proguard obfuscation in rultor merge script#1342
yegor256 wants to merge 1 commit into
masterfrom
1305

Conversation

@yegor256

@yegor256 yegor256 commented Sep 3, 2026

Copy link
Copy Markdown
Member

Fixes #1305.

Problem

Every @rultor merge fails on rultor's yegor256/java image (JDK 21):

Failed to execute goal com.github.wvengen:proguard-maven-plugin:2.7.0:proguard (default)
on project lints: Obfuscation failed (result=1)

The proguard profile in pom.xml activates on JDK [,22), so it's active on rultor's JDK 21 but not on a locally used JDK 23 — which is why mvn clean install -Pqulice passes locally while the merge check fails. ProGuard 2.7.0 needs --add-opens to read JDK classes on JDK 21+, and obfuscation doesn't add anything to a merge check anyway — it only matters for the deployed artifact.

The release script already works around exactly this (exports MAVEN_OPTS and passes !proguard), but the merge script did neither.

Fix

Align the merge script in .rultor.yml with the release script:

merge:
  script: |
    export MAVEN_OPTS="--add-opens java.base/java.util=ALL-UNNAMED --add-opens java.base/java.lang.reflect=ALL-UNNAMED"
    mvn clean install -ntp -P!hone,!proguard,qulice --errors -Dstyle.color=never

Changes

  • .rultor.yml — export MAVEN_OPTS and exclude the proguard profile in the merge script.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Aav9e7z6jdPsj47FrtbxJY


Generated by Claude Code

The merge script ran mvn without excluding the `proguard` profile or
setting MAVEN_OPTS, so on JDK 21 (rultor's yegor256/java image) the
profile activates and proguard-maven-plugin 2.7.0 fails to obfuscate
without --add-opens. Align merge with the release script, which
already works around this and skips obfuscation entirely since it
only matters for the deployed artifact.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Aav9e7z6jdPsj47FrtbxJY

yegor256 commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

The zizmor check failed, but it's not related to this PR's diff (which only touches .rultor.yml). The job log shows:

fatal: no audit was performed
'known-vulnerable-actions' audit failed on file://./.github/workflows/copyrights.yml

Caused by:
    0: error in 'known-vulnerable-actions' audit
    1: request error while accessing GitHub API
    2: Cache error: Cache error: error sending request for url (https://api.github.com/advisories?ecosystem=actions&affects=yegor256%2Fcopyrights-action%400.0.12)

This is a network error from zizmor's online known-vulnerable-actions audit calling api.github.com/advisories, unrelated to any workflow file this PR changes. I don't have permission to re-run the job (rerun-failed-jobs returned a 403), so I can't confirm it clears on retry myself. Flagging it here and leaving the PR watched.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rultor merge fails due to proguard obfuscation activation on JDK 21

2 participants