ci: stop double-running test workflows on PR branches#181
Merged
Conversation
All seven test-* workflows triggered on both push and pull_request with no branch filter, so every push to a PR branch fired both events: two runs each. Restrict push to main: PR branches now trigger only pull_request, and a merge to main triggers only push. pull_request stays unfiltered so PRs against any base still run. Roughly halves Actions usage for these workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All seven
test-*workflows triggered on bothpushandpull_requestwith no branch filter:So every push to a PR branch fires both events, running each workflow twice.
Fix
Restrict
pushtomain(same change just applied to oasdiff):pull_request(one run).maintriggers onlypush(one run).pull_requeststays unfiltered so PRs against any base branch still run.No coverage lost: every change runs on its PR and again on
mainafter merge. Roughly halves Actions usage across these seven workflows.