Skip symbol check when tools are unavailable - #3
Merged
Conversation
ronag
marked this pull request as ready for review
July 12, 2026 11:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nmis not installedc++filtis not installedWhy
This follows up on the post-merge review comment on #2. The test assumed both binutils-style tools were present on every non-Windows system, so otherwise valid CI images and developer machines could fail for an environmental reason unrelated to the addon.
Impact
The native symbol validation remains strict wherever both tools are available. Environments missing either optional diagnostic tool now receive an explicit test skip instead of a hard failure.
Validation
PATH: symbol test skipped withnm is not availablePATHcontaining onlynm: symbol test skipped withc++filt is not available