Skip to content

Skip symbol check when tools are unavailable - #3

Merged
ronag merged 1 commit into
mainfrom
codex/skip-missing-symbol-tools
Jul 12, 2026
Merged

Skip symbol check when tools are unavailable#3
ronag merged 1 commit into
mainfrom
codex/skip-missing-symbol-tools

Conversation

@ronag

@ronag ronag commented Jul 12, 2026

Copy link
Copy Markdown
Member

Summary

  • skip the unresolved-symbol test when nm is not installed
  • skip the same test when c++filt is not installed
  • continue to fail for other process-launch errors, nonzero tool exits, and unresolved vendored symbols

Why

This follows up on the post-merge review comment on #2. The test assumed both binutils-style tools were present on every non-Windows system, so otherwise valid CI images and developer machines could fail for an environmental reason unrelated to the addon.

Impact

The native symbol validation remains strict wherever both tools are available. Environments missing either optional diagnostic tool now receive an explicit test skip instead of a hard failure.

Validation

  • Node 26.5.0 on macOS arm64: full native rebuild, 14/14 runtime tests, and TypeScript tests passed
  • empty PATH: symbol test skipped with nm is not available
  • isolated PATH containing only nm: symbol test skipped with c++filt is not available

@ronag
ronag marked this pull request as ready for review July 12, 2026 11:06
@ronag
ronag merged commit 3bd5230 into main Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant