refactor(theme)!: rename the ui.tv merge keys and drop deprecated gradient utilities - #7007
Conversation
…radient utilities
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (6)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe TV configuration keys changed from Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The public configuration rename and Tailwind utility updates are documented and consistently wired through the implementation, with no remaining merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 5 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
commit: |
🔗 Linked issue
Part of #6918, Epic H of #6610. Split out of #7006 so it lands whichever way that one goes.
❓ Type of change
📚 Description
Two cleanups that came out of measuring the
cnswap and do not depend on it.app.config.ui.tvdrops thetwprefix.twMergebecomesmergeandtwMergeConfigbecomesmergeConfig. The keys were named aftertailwind-merge, which is an implementation detail of the engine rather than something you pick, and naming them after it means the public surface moves whenever the merger does. Same shape, same capability,TWMergeConfigunchanged since it is still that library's config type.The themes move off
bg-gradient-to-*. Tailwind deprecated it in favour ofbg-linear-*in v4. Same CSS, so this is the 20 snapshot lines and nothing else.marquee.tsandpage-aside.tswere the only files using it, and the rest of the deprecated v4 aliases (flex-shrink-*,flex-grow-*,overflow-ellipsis) appear nowhere in source.It also removes the one case where
tailwind-mergegets our own classes wrong: it readsbg-gradient-to-bas a background color, so a laterbg-<color>on the same slot dropped the gradient.bg-linear-*is classified correctly. That was the only family left in a 200,000-chain differential over the generated themes.📝 Checklist