Skip to content

docs(navigation-menu): clarify which slot styles children in vertical orientation - #7004

Merged
benjamincanac merged 1 commit into
nuxt:v4from
lazerg:fix/issue-7002-navigationmenu-childlink-slot
Sep 22, 2026
Merged

benjamincanac merged 1 commit into
nuxt:v4from
lazerg:fix/issue-7002-navigationmenu-childlink-slot

Conversation

@lazerg

@lazerg lazerg commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Resolves #7002

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

ui.childLink gets reported as broken in vertical orientation every few months (#7002, #5388, #5223). Children are rendered recursively as items there, so ui.link styles them, and nothing in the docs says so.

This adds a note under Orientation naming which key applies where, including the collapsed popover where childLink is still used. Behavior is unchanged, so #7002 can be closed as a duplicate.

The same note applies to v5, happy to open a companion PR there.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions Bot added the v4 #4488 label Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 8c8b40b6-9727-4ee4-aa80-ce4cea244030

📥 Commits

Reviewing files that changed from the base of the PR and between eb82975 and 0f71caf.

📒 Files selected for processing (1)
  • docs/content/docs/2.components/navigation-menu.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/content/docs/2.components/navigation-menu.md

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The Navigation Menu documentation now explains slot usage by orientation. Vertical children render through the link slot. The childLink slot applies to horizontal content menus and collapsed popovers.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies a documentation clarification about which slot styles children in vertical Navigation Menu orientation.
Description check ✅ Passed The description directly explains the documentation change, the affected slots, the unchanged behavior, and the related issue.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Sep 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing lazerg:fix/issue-7002-navigationmenu-childlink-slot (0f71caf) with v4 (8b7f328)

Open in CodSpeed

@pkg-pr-new

pkg-pr-new Bot commented Sep 21, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@nuxt/ui@7004

commit: 0f71caf

@benjamincanac benjamincanac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lazerg! 😊 No need to forward this to v5, this will be done through rebase and this component will be split into two in v5 anyway: a NavigationMenu and a NavigationAccordion. Grouping the two under an orientation prop was my mistake since they have different behavior. I've marked this PR as resolving #7002.

@benjamincanac
benjamincanac merged commit e47e2dd into nuxt:v4 Sep 22, 2026
24 checks passed

This branch was successfully deployed

1 active deployment
Preview – ui 0f71caf9 Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NavigationMenu: childLink data slot is showing link instead of childLink

2 participants