docs(navigation-menu): clarify which slot styles children in vertical orientation - #7004
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe Navigation Menu documentation now explains slot usage by orientation. Vertical children render through the Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
eb82975 to
0f71caf
Compare
There was a problem hiding this comment.
Thanks @lazerg! 😊 No need to forward this to v5, this will be done through rebase and this component will be split into two in v5 anyway: a NavigationMenu and a NavigationAccordion. Grouping the two under an orientation prop was my mistake since they have different behavior. I've marked this PR as resolving #7002.
🔗 Linked issue
Resolves #7002
❓ Type of change
📚 Description
ui.childLinkgets reported as broken inverticalorientation every few months (#7002, #5388, #5223). Children are rendered recursively as items there, soui.linkstyles them, and nothing in the docs says so.This adds a note under Orientation naming which key applies where, including the collapsed popover where
childLinkis still used. Behavior is unchanged, so #7002 can be closed as a duplicate.The same note applies to
v5, happy to open a companion PR there.📝 Checklist