feat(Modal): accept breakpoint values in fullscreen prop - #6900
Draft
benjamincanac wants to merge 1 commit into
Draft
benjamincanac wants to merge 1 commit into
benjamincanac wants to merge 1 commit into
Conversation
Merging this PR will improve performance by 11.65%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | plain <button> |
1.3 ms | 1.2 ms | +11.65% |
Tip
Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.
Comparing feat/modal-fullscreen-breakpoint (9870052) with v4 (ae24311)
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Making a modal fullscreen only on mobile currently requires overriding the theme's slots, variants and compound variants in
app.config.ts. This adds breakpoint values to thefullscreenprop so it works out of the box:<UModal fullscreen="sm" />The prop is now typed
boolean | 'sm' | 'md' | 'lg', a breakpoint makes the modal fullscreen below it and a regular dialog above it. Works withscrollableas well, the content getsmin-h-dvhbelow the breakpoint so it actually fills the screen.ContentSearchandDashboardSearchsize their modal through thefullscreenvariant, so their themes get matching breakpoint keys and forwarding a breakpoint through them works too.Also fixes the theme template generation for variants mixing boolean and string keys: the generated
as typeof x[number]cast included thetrue/falsekeys, which tailwind-variants types asboolean, breaking typecheck on the generated compound variants.📝 Checklist