Skip to content

fix: resolve issue #889 - #890

Open
harlan-zw wants to merge 1 commit into
mainfrom
fix/issue-889
Open

fix: resolve issue #889#890
harlan-zw wants to merge 1 commit into
mainfrom
fix/issue-889

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

📚 Description

Closes #889.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
scripts-playground Error Error Sep 6, 2026 7:10am UTC

Request Review

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedminiflare@​4.20260730.09910010096100

View full report

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: fbd783fd-5349-4271-bdd8-f6f562b410f7

📥 Commits

Reviewing files that changed from the base of the PR and between 9368f01 and cc309b5.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • package.json
  • packages/script/src/runtime/server/utils/network-dispatcher.platform.ts
  • pnpm-workspace.yaml
  • test/unit/network-dispatcher-workerd.test.ts
  • test/unit/network-host.test.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The platform network dispatcher now binds globalThis.fetch to globalThis and returns a PublicNetworkDispatcher. The workspace adds Miniflare and workerd build configuration. Tests cover detached dispatcher calls in Node and workerd for GET, streamed POST, and string POST requests.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to cc309

The proxy dispatcher now forwards requests successfully in workerd environments instead of failing from an invalid fetch receiver, with request forwarding covered for GET and POST bodies. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title identifies the issue being fixed, but it does not state that the change fixes the Umami first-party proxy on Cloudflare Workers. It is too generic for a clear history summary. Use a specific title such as "fix: restore Umami proxy requests on Cloudflare Workers".
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset because it states that the pull request closes issue #889 and includes the required AI disclosure. The description is sparse, but it is not off-topic.
Linked Issues check ✅ Passed The changes address issue #889. The dispatcher now binds fetch to globalThis, which prevents the Cloudflare Workers Illegal invocation failure. Workerd integration tests cover GET requests and s…
Out of Scope Changes check ✅ Passed The dependency, workspace configuration, dispatcher fix, and tests are all directly related to reproducing or fixing the Cloudflare Workers proxy failure. No unrelated code changes are shown. The excl…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (2 skipped: 2 …
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-889

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@harlan-zw harlan-zw added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Sep 6, 2026
@harlan-zw

harlan-zw commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 BLOCKED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. A person still decides the merge.

  • Merge gate: Passed.
  • Review gate: Passed. No material issues.
  • CI gate: BLOCKED. typecheck failed.

@harlan-zw harlan-zw added harlan-agent-blocked The automated Review found a material defect in this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

harlan-agent-blocked The automated Review found a material defect in this head commit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Umami first-party proxy returns 502 on Cloudflare Workers with @nuxt/scripts 1.3.5+

1 participant