fix: respect app.baseURL in devtools iframe src#322
fix: respect app.baseURL in devtools iframe src#322
app.baseURL in devtools iframe src#322Conversation
📝 WalkthroughWalkthroughThis pull request adds a runtime dependency on the Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 51: package.json was updated to add the "ufo" dependency but the pnpm
lockfile wasn't regenerated, which breaks CI with frozen-lockfile; run pnpm
install (or pnpm install --lockfile-only) locally to regenerate pnpm-lock.yaml,
verify the lockfile includes the new "ufo" entry, and commit the updated
pnpm-lock.yaml alongside the package.json change so CI/release can proceed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 31d2084b-0637-4e99-8852-622fbe03eed8
📒 Files selected for processing (2)
package.jsonsrc/devtools.ts
commit: |
Summary
app.baseURLis set to a non-root value (e.g., behind a reverse proxy)joinURLfromufoto prependapp.baseURLto the devtools iframesrcFixes #321
Context
This is the same bug that was reported and fixed in
@nuxt/a11y:Changes
src/devtools.ts: ImportjoinURLfromufoand wrapDEVTOOLS_UI_ROUTEwithjoinURL(nuxt.options.app?.baseURL || '/', DEVTOOLS_UI_ROUTE)in theaddCustomTabcallpackage.json: Addufoas an explicit dependency