Repository navigation
Fix gcsm alias passing the commit message as a path - #1297
Merged
Merged
Conversation
Contributor
|
ok, let me know when you're ready |
DavSanchez
marked this pull request as ready for review
October 21, 2026 17:23
Contributor
Author
|
@fdncred ready! |
Contributor
|
looks like we have some conflicts now |
`gcsm` expanded to `git commit --all --signoff $message`, which hands
the message to git as a pathspec, so it fails with "pathspec did not
match" (or commits unrelated files if a file happens to share the
name). It should mirror `gcasm` minus the `--all`, as in oh-my-zsh:
alias gcsm='git commit --signoff --message'
Also add `gcsm` to the abbreviation file, which mirrored every other
alias in this file except this one.
DavSanchez
force-pushed
the
fix/git-gcsm-signoff-message
branch
from
October 21, 2026 21:55
3842709 to
e501893
Compare
Contributor
Author
|
Fixed! |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcsmwas defined as:export def gcsm [message: string] { git commit --all --signoff $message }The message is passed as a positional argument, so git treats it as a
pathspec:
(and if a file with that name existed, it would commit that file with no
message at all). It also duplicated
gcasm's--all. In oh-my-zsh, whosegit plugin this file is ported from, it is:
which is exactly
gcasmminus--all, so that is what this changes it to.The abbreviation file mirrored every other alias in
git-aliases.nuexceptthis one (and
gwta, which has an argument-taking definition), so addgcsmthere as well.