Repository navigation
Fix modules still using 1-based split column names - #1294
Merged
fdncred merged 1 commit intoOct 21, 2026
Merged
Conversation
split column now names its columns from column0, so a few modules were reading the wrong column. from cpuinfo also used get inside update closures, which now get the cell value.
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split columnnames its columns fromcolumn0now (nushell/nushell#17064), so a few modules were still reading the wrong column.from cpuinforeplaced spaces in the values instead of the keys, socpu MHzstayed as is andflagsturned into one longfpu_vme_de...string. It also usedget column1/get flagsinsideupdateclosures, which now get the cell value and not the row, so it errored on any input. Switched tostr replace ... column0andupdate flags { split row ' ' }.from dmidecodelowercased the values instead of the keysclone-allasked forcolumn2oforg/repo, which doesn't exist anymore.grab repo namewas also typed asstring -> stringbut is called with no input, soclone allfailed with "Pipeline empty". Changed it tonothing -> string.fuzzy-command-searchtook the description instead of the command name from the fzf linegit status --porcelain=2, so the staged and modified counts were offcolumn2of thelspci -xxxlines, the hex bytes are incolumn1nowI tested each one with nu 0.116.1 against sample input (a fake /proc/cpuinfo, dmidecode output, porcelain v2 lines, lspci lines and a stubbed
gh). They all error or give wrong output on main and give the right result with this change.toolkit check prpasses.