Repository navigation
cargo completions: make --timings a switch - #1293
Merged
Merged
Conversation
Contributor
|
This could also be a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1154
--timingswas declared as--timings: stringin the cargo externs, so nushell expects a value after it andcargo build --timingsfails with "Missing flag argument". In cargo the value is optional (--timings[=<FMTS>]) and the plain flag is how it's normally used.Changed it to a switch in all 7 places (build, check, doc, test, bench, install, clippy).
Tested with a stub
cargothat just echoes its argsBefore this it errored with
nu::parser::missing_flag_param. It also stopscargo test --timings --releasefrom treating--releaseas the timings value.