Repository navigation
zoxide-menu: keep the full score when parsing zoxide output - #1292
Merged
Merged
Conversation
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zoxide menu parses
zoxide query -lswith(?P<description>[0-9]+) (?P<value>.+). zoxide prints the score with one decimal ({score:>6.1}), so a line like12.0 /home/user/projectsonly matched from the last digit and the description column showed0instead of12.0.This changes the regex to take the whole score, including the decimal part, and allow any amount of whitespace before the path. Same thing jabdinghoff suggested in #1126.
Checked with a fake
zoxidethat prints two lines. The menu now shows12.0and4.5where before it was0and5.toolkit check prpasses.This doesn't touch the cwd prefix part of #1126, which looks like the reedline partial completion bug discussed there.