Remove _DTypeLike aliases in favor of _numtype.ToDType#856
Open
Aniketsy wants to merge 3 commits intonumpy:mainfrom
Open
Remove _DTypeLike aliases in favor of _numtype.ToDType#856Aniketsy wants to merge 3 commits intonumpy:mainfrom
Aniketsy wants to merge 3 commits intonumpy:mainfrom
Conversation
jorenham
requested changes
Apr 18, 2026
| _CastingSafe: TypeAlias = Literal["no", "equiv", "safe", "same_kind", "same_value"] | ||
| _CastingUnsafe: TypeAlias = Literal["unsafe"] | ||
|
|
||
| _ToDTypeBool: TypeAlias = _nt.ToDTypeBool |
| _ToDTypeFloat: TypeAlias = _nt.ToDTypeFloat16 | _nt.ToDTypeFloat32 | _nt.ToDTypeFloat64 | _nt.ToDTypeLongDouble | ||
| _ToDTypeComplex: TypeAlias = _nt.ToDTypeComplex64 | _nt.ToDTypeComplex128 | _nt.ToDTypeCLongDouble | ||
| _ToDTypeComplex_co: TypeAlias = _ToDTypeBool | _ToDTypeUInt | _ToDTypeInt | _ToDTypeFloat | _ToDTypeComplex | ||
| _ToDTypeObject: TypeAlias = _nt.ToDTypeObject |
| _CoFloat: TypeAlias = float | _nt.co_float | ||
| _CoComplex: TypeAlias = complex | _nt.co_complex | ||
|
|
||
| _ToDType = TypeAliasType("_ToDType", _nt._ToDType[_ScalarT], type_params=(_ScalarT,)) |
Member
There was a problem hiding this comment.
this alias is equivalent to _nt.ToDType, so we should just use it directly and remove this
Comment on lines
+29
to
+30
| _ToDTypeUInt32: TypeAlias = _nt.ToDTypeUInt32 | ||
| _ToDTypeUInt64: TypeAlias = _nt.ToDTypeUInt64 |
Member
There was a problem hiding this comment.
There's no need for these aliases anymore now
| import numpy as np | ||
| import numpy.typing as npt | ||
| from numpy._typing import _DTypeLike, _DTypeLikeVoid | ||
| from numpy._typing import _DTypeLike |
Member
There was a problem hiding this comment.
_DTypeLike could also be replaced with _nt.ToDType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #566