Repository navigation
Remove unused files and simplify the tsconfig layering - #263
Merged
Merged
Conversation
- packages/beatoraja-skin/.prettierignore: prettier is no longer a dependency; the root vite.config.ts fmt.ignorePatterns already skips the fixtures. - scripts/create-demo-json.ts: nothing runs it. - examples/test/benchmark-command-mix-100.bms and ogg-test.wav: no test or benchmark reads them.
Vite+ already manages the toolchain: vp env reads .node-version (as setup-vp does in CI), and package.json pins pnpm through packageManager. mise.toml duplicated the Node setting and asked for pnpm@latest, which contradicted that pin.
Each package's tsconfig.build.json now extends tsconfig.options.json directly and sets declaration and isolatedDeclarations itself, so tsconfig.build.options.json goes away. The shared options no longer turn on composite and declaration only for the typecheck config to turn them back off. Nothing builds through tsc's project references, so the clean scripts stop deleting tsconfig.tsbuildinfo. vp pack's output is byte-identical before and after.
Every other published package ships the MIT LICENSE; @be-music/player-web was missing it.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
be-music-player-demo | aec878c | Commit Preview URL Branch Preview URL |
Oct 11 2026, 11:45 AM |
Exports Benchmark
Summary
Top Regressions
Top ImprovementsNo improvement over threshold. Excluded (sub-timer-resolution)Per-call latency at or below 0.001ms on at least one side — the reported time is measurement noise, not the case's real cost, so no percent change is shown.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/beatoraja-skin/.prettierignore: prettier is gone, and the rootfmt.ignorePatternsalready skips the fixtures.scripts/create-demo-json.ts: nothing runs it.examples/test/benchmark-command-mix-100.bmsandexamples/test/ogg-test.wav: no test or benchmark reads them. Their README rows (English and Japanese) are dropped too.mise.tomlin favour of Vite+:vp envand CI'ssetup-vpread.node-version.packageManagerpins pnpm.mise.tomlasked forpnpm@latest, which contradicted that pin.tsconfig.build.options.jsonis gone. Eachpackages/*/tsconfig.build.jsonextendstsconfig.options.jsonand setsdeclarationandisolatedDeclarationsitself.composite/declarationfortsconfig.typecheck.jsonto turn them back off.cleanscripts stop deleting atsconfig.tsbuildinfothat is never produced.LICENSEtopackages/player-web, the only published package without one.Test plan
pnpm buildoutput (174.js/.d.tsfiles underpackages/*/dist) is byte-identical before and after the tsconfig change.pnpm run check(format, lint, types)pnpm test(2303 tests)🤖 Generated with Claude Code