Skip to content

fix(otel): don't combine WithTLSClientConfig with WithInsecure #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blue4209211 merged 1 commit into from
Jul 15, 2026
Merged

fix(otel): don't combine WithTLSClientConfig with WithInsecure #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion logs/otel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,11 @@ func Init(machineId, hostname, version string) {
otlplogshttp.WithEndpoint(endpointUrl.Host),
otlplogshttp.WithURLPath(path),
otlplogshttp.WithHeaders(common.AuthHeaders()),
otlplogshttp.WithTLSClientConfig(&tls.Config{InsecureSkipVerify: *flags.InsecureSkipVerify}),
}
if endpointUrl.Scheme != "https" {
opts = append(opts, otlplogshttp.WithInsecure())
} else {
opts = append(opts, otlplogshttp.WithTLSClientConfig(&tls.Config{InsecureSkipVerify: *flags.InsecureSkipVerify}))
Comment thread
blue4209211 marked this conversation as resolved.
}
client := otlplogshttp.NewClient(opts...)
exporter, _ := otlplogs.NewExporter(context.Background(), otlplogs.WithClient(client))
Expand Down
3 changes: 2 additions & 1 deletion tracing/tracing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,11 @@ func Init(machineId, hostname, version string) {
otlptracehttp.WithEndpoint(endpointUrl.Host),
otlptracehttp.WithURLPath(path),
otlptracehttp.WithHeaders(common.AuthHeaders()),
otlptracehttp.WithTLSClientConfig(&tls.Config{InsecureSkipVerify: *flags.InsecureSkipVerify}),
}
if endpointUrl.Scheme != "https" {
opts = append(opts, otlptracehttp.WithInsecure())
} else {
opts = append(opts, otlptracehttp.WithTLSClientConfig(&tls.Config{InsecureSkipVerify: *flags.InsecureSkipVerify}))
Comment thread
blue4209211 marked this conversation as resolved.
}
client := otlptracehttp.NewClient(opts...)
exporter, err := otlptrace.New(context.Background(), client)
Expand Down
Loading