sn: cache session tokens authentication results in REPLICATE#4082
Draft
carpawell wants to merge 1 commit into
Draft
sn: cache session tokens authentication results in REPLICATE#4082carpawell wants to merge 1 commit into
carpawell wants to merge 1 commit into
Conversation
Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
| @@ -0,0 +1,10 @@ | |||
| package timecore | |||
|
|
||
| import "time" | ||
|
|
||
| // TimeProvider supplies current FS chain time without calling the chain. |
Contributor
There was a problem hiding this comment.
interface may have wider applications than just FS chain (even the name hints at it), so I'd give him a more general description
| cache *lru.Cache[[sha256.Size]byte, error] | ||
| } | ||
|
|
||
| func (ch sessionV2Checker) authenticateV2Token(s *sessionv2.Token, fsChain HistoricN3ScriptRunner, tp timecore.TimeProvider) error { |
Contributor
There was a problem hiding this comment.
implementation is close to already existing session cache. I expect single component for all cases
| resErr, ok := ch.cache.Get(k) | ||
| if !ok { | ||
| resErr = AuthenticateTokenV2(s, fsChain) | ||
| defer func() { |
Contributor
There was a problem hiding this comment.
further panic is possible or why defer?
| } | ||
|
|
||
| currentTime := tp.Now().Round(time.Second) | ||
| if s.Exp().Before(currentTime) { |
Contributor
There was a problem hiding this comment.
have these checks been done before?
Contributor
|
missed that PR is still in draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.