Skip to content

sn: attach meta header to GET streams#4072

Open
carpawell wants to merge 1 commit into
masterfrom
fix/attach-meta-headers-for-GET-stream-messages
Open

sn: attach meta header to GET streams#4072
carpawell wants to merge 1 commit into
masterfrom
fix/attach-meta-headers-for-GET-stream-messages

Conversation

@carpawell

Copy link
Copy Markdown
Member

This affects only

  1. any REP objects;
  2. EC parts;
  3. EC full object with RANGE.

This does not affect case implemented in #3996 (Get service's Prm with WithECTransport() called). Refs #4071.

This affects only
1. any REP objects;
2. EC parts;
3. EC full object with RANGE.

This does not affect case implemented in #3996 (Get service's Prm with
`WithECTransport()` called).
Refs #4071.
Refs nspcc-dev/neofs-api#397.

Signed-off-by: Pavel Karpy <carpawell@nspcc.io>
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.30%. Comparing base (5df4d7b) to head (ec3c5a5).

Files with missing lines Patch % Lines
pkg/services/object/server.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4072      +/-   ##
==========================================
+ Coverage   26.29%   26.30%   +0.01%     
==========================================
  Files         671      671              
  Lines       45865    45865              
==========================================
+ Hits        12060    12065       +5     
+ Misses      32673    32670       -3     
+ Partials     1132     1130       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@carpawell carpawell changed the title sn: attach meta header to GET's streams sn: attach meta header to GET streams Jul 8, 2026
roman-khimov
roman-khimov previously approved these changes Jul 8, 2026

@roman-khimov roman-khimov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something to tell about in chlog?

@carpawell

Copy link
Copy Markdown
Member Author

PR adds a metaheader to every message. This is how i read the spec currently. But i think @cthulhu-rider thinks differently. Once we decide i will update chlog.

@roman-khimov roman-khimov dismissed their stale review July 9, 2026 20:12

Let's settle the API thing first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants