Repository navigation
Conversation
nREPL 1.8.0 fixes reading past the end of stdin, which threw a ClassCastException in 1.7.0, so the Clojure profile passes stdin.eof now too. proof serve already gives the same replies as 1.8.0 for the code it understands, going by transcripts of the two. The eof-error scenario stays, as 1.7.0 is what CIDER injects, but -like clojure behaves like 1.8.0 and leaves it out. The links into nREPL's code point at the 1.8.0 release, with the lines of session.clj moved down by the code 1.8.0 added above them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.8.0 fixes the stdin EOF ClassCastException, so nREPL passes every check now. The eof-error scenario stays, since 1.7.0 is still what CIDER injects, but
-like clojureleaves it out.