fix(arborist): retain explicit optional peers with --no-save - #9942
Closed
wangxpych wants to merge 1 commit into
Closed
fix(arborist): retain explicit optional peers with --no-save#9942wangxpych wants to merge 1 commit into
wangxpych wants to merge 1 commit into
Conversation
Author
|
Closing because I’m stepping back from maintaining this contribution. Thanks for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-savereificationProblem
With an existing lockfile, a package already declared as an optional peer can be resolved for an explicit
npm install --no-save <package>request and then marked extraneous during dependency flag recalculation. The pruning pass removes it again, so npm reports the project as up to date.Testing
npm test --workspace @npmcli/arboristinstall --no-savedoes not install anything #9024; after the fixeslint-plugin-jest@29.16.6is installed whilepackage.jsonandpackage-lock.jsonhashes remain unchangedFixes #9024