fix(install): reload user config after preinstall - #9909
Open
arhxam wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
npm 12 runs a local root
preinstallbefore Arborist fetches dependencies, butnpm installcurrently freezes its Arborist options before that hook. A credential helper can therefore replace an expired token in the configured user.npmrc, yet the active install still sends the old token and fails; only a second invocation succeeds.Change
Config#reload(where)for already-loaded file-backed config layers. Reloading clears removed values, preserves the existing precedence chain, and invalidates flattened options.preinstalland derive Arborist/script-policy options from the refreshed config.--ignore-scriptsbehavior unchanged.Testing
node ../../bin/npm-cli.js test -- --no-coveragefromworkspaces/confignode . run test -- test/lib/commands/install.js --no-coveragenode . run testpreinstallreplaced the token, then both the packument and tarball requests used the fresh bearer token and the firstnpm installcompleted.References
Fixes #9853
AI assistance
This change was developed with AI assistance. I reproduced the stale-token behavior against the current
latestbranch, reviewed the credential/config precedence path, and ran the checks above locally.