Skip to content

fix(ci): allow omitted bundled dependencies in lockfile validation #9908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arhxam wants to merge 2 commits into
base: latest
Choose a base branch
from
+26 −1
Open

fix(ci): allow omitted bundled dependencies in lockfile validation #9908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa14e03
test(ci): cover unlocked bundled dependencies
arhxam Aug 22, 2026
47741fa
fix(ci): ignore unlocked bundled dependencies
arhxam Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/utils/validate-lockfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ function validateLockfile (virtualTree, idealTree) {
const lock = virtualTree.get(key)

if (!lock) {
errors.push(`Missing: ${entry.name}@${entry.version} from lock file`)
// Bundled dependencies are extracted from their parent's tarball and
// may not have independent lockfile entries.
if (!entry.inBundle) {
errors.push(`Missing: ${entry.name}@${entry.version} from lock file`)
}
continue
}

Expand Down
21 changes: 21 additions & 0 deletions test/lib/utils/validate-lockfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,27 @@ t.test('extra inventory items on idealTree', async t => {
)
})

t.test('missing bundled inventory items do not invalidate lockfile', async t => {
const errors = validateLockfile(
new Map([
['node_modules/bundle', { name: 'bundle', version: '1.0.0' }],
]),
new Map([
['node_modules/bundle', { name: 'bundle', version: '1.0.0' }],
['node_modules/bundle/node_modules/embedded', {
name: 'embedded',
version: '1.0.0',
inBundle: true,
}],
['node_modules/missing', { name: 'missing', version: '2.0.0' }],
])
)

t.strictSame(errors, [
'Missing: missing@2.0.0 from lock file',
], 'bundled nodes are supplied by their parent tarball, while ordinary nodes remain required')
})

t.test('extra inventory items on virtualTree', async t => {
t.matchSnapshot(
validateLockfile(
Expand Down