Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm publish ./pkg.tgzandnpm pack ./pkg.tgzfail withEALLOWFILEwhenallow-fileisnoneorroot. The tarball named on the command line is the package being packed or published, not a dependency, but the dependency fetch policy was still applied to it when reading its manifest and tarball.This does for
filespecs what #9756 did fordirectoryspecs:pack,publishand libnpmpack setallowFile: 'all'when the target itself is a local tarball. Dependency fetches are unchanged.Testing
Added
allow-file=none|rootcases for a tarball target to the pack, publish and libnpmpack tests. They fail withEALLOWFILEbefore the change and pass after. The full suite passes locally.References
Fixes #10144