Repository navigation
fix(patch): exclude .git when copying tarballs into the rebase repo - #10143
Open
rootvector2 wants to merge 1 commit into
Open
rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm patch updaterebases the existing patch in a throwaway git repo.#rebasePatchextracts the base and target dependency versions with pacote and copies each tree into that repo withfs.cp. pacote keeps a tarball's own.git/on extract, so a dependency can ship an executable.git/hooks/pre-commit(or a.git/configwithcore.fsmonitor) that the copy lays over the work repo, and thegit add/git commitright after run it. A publisher of a package you patch then gets code execution the moment you runnpm patch updateon it, with no install-script prompt in the path.The copy that goes the other way (repo into the edit dir) already filters
.gitwithnotGitDir; the two copies into the repo did not. Pass the same filter to both so a tarball's.gitnever reaches the rebase repo.Added a regression test that serves a 2.0.0 tarball carrying an executable
pre-commithook; it runs on the current tree and does not after the fix.