Repository navigation
Conversation
A package's `publishConfig` can set `tag`, eg `"publishConfig": { "tag": "next" }`. npm publishes with it, since `publishConfig` is flattened into `opts` and the publish uses `opts.defaultTag`, but the "Publishing to … with tag …" notice, and the `npm stage` "has been staged with tag …" notice, printed `defaultTag`, which is read from the CLI config before `publishConfig` is applied. So `npm publish` said "with tag latest" while publishing to `next`.
Both notices now print `opts.defaultTag`, the tag actually used, with tests for `npm publish` and `npm stage`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A package's
publishConfigcan settag, eg"publishConfig": { "tag": "next" }. npm publishes with it, sincepublishConfigis flattened intooptsand the publish usesopts.defaultTag, but the "Publishing to … with tag …" notice, and thenpm stage"has been staged with tag …" notice, printeddefaultTag, which is read from the CLI config beforepublishConfigis applied. Sonpm publishsaid "with tag latest" while publishing tonext.Both notices now print
opts.defaultTag, the tag actually used, with tests fornpm publishandnpm stage.