Repository navigation
Conversation
…ere is no lockfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no lockfile and no root
node_modules, a workspace has noLinkyet, so the missing-edge walk in#initTreenever reaches the packages already installed under it. Their missing dependencies are never queued, andnpm installexits 0 with an incomplete tree and lockfile.This makes the walk also descend from each workspace's edges when it visits the project root. It walks into what the workspace has installed rather than the workspace itself: queueing the workspace there, ahead of the root, bypasses the workspaces filter and changes hoisting (it breaks the filtered-reification tests in
reify.js).This overlaps #9985, which changes the same walk to follow workspace links. Neither depends on the other: #9985 covers the case where the link exists, this one the case where it does not. Whichever lands second needs a small rebase.
Checked locally on
7b50811:--install-strategy=linkedand--workspace=aworkspaces/arborist: all tests pass with coverage at 100%, lint cleanFixes #10011