Skip to content

fix(ui): add default aria-label to toggle - #9024

Open
avivkeller wants to merge 3 commits into
mainfrom
avivkeller-patch-3
Open

fix(ui): add default aria-label to toggle#9024
avivkeller wants to merge 3 commits into
mainfrom
avivkeller-patch-3

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Fixes #9023

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings July 27, 2026 23:04
@avivkeller
avivkeller requested a review from a team as a code owner July 27, 2026 23:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jul 27, 2026 11:07pm

Request Review

@cursor

cursor Bot commented Jul 27, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Small a11y default on a UI component; optional prop override behavior is unchanged.

Overview
ThemeToggle now defaults ariaLabel to 'Select theme' when callers omit it, so the icon-only trigger always exposes an accessible name on the aria-label attribute.

A patch changeset documents the @node-core/ui-components release. Custom labels via the existing ariaLabel prop are unchanged.

Reviewed by Cursor Bugbot for commit 2ae8129. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b250ed3. Configure here.

Comment thread packages/ui-components/src/Common/ThemeToggle/index.tsx Outdated
Add a default aria-label to the ThemeToggle component.

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings July 27, 2026 23:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings July 27, 2026 23:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@avivkeller

Copy link
Copy Markdown
Member Author

@nodejs/web-admins can you disable automatic copilot review for this repo, we have cursor

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.07%. Comparing base (8a6f1b8) to head (2ae8129).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9024      +/-   ##
==========================================
- Coverage   75.12%   75.07%   -0.05%     
==========================================
  Files         102      102              
  Lines        9109     9109              
  Branches      372      373       +1     
==========================================
- Hits         6843     6839       -4     
- Misses       2262     2266       +4     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 10.65 MB
New Total First Load JS 10.65 MB
Delta 0 B (0.00%)

@MattIPv4

Copy link
Copy Markdown
Member

@nodejs/web-admins can you disable automatic copilot review for this repo, we have cursor

https://github.com/community/maintainers/discussions/845

@avivkeller

Copy link
Copy Markdown
Member Author

@nodejs/web-admins can you disable automatic copilot review for this repo, we have cursor

community/maintainers#845

I think they said it can be disabled in that thread.

@MattIPv4

Copy link
Copy Markdown
Member

I think they said it can be disabled in that thread.

Indeed, though they've also said they're reverting it this week, so I'm planning to wait for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing aria label and title on "theme toggle" button

3 participants