Skip to content

buffer: add missing binding typings - #66328

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:buffer-binding-typings
Closed

panva wants to merge 1 commit into
nodejs:mainfrom
panva:buffer-binding-typings

Conversation

@panva

@panva panva commented Sep 26, 2026

Copy link
Copy Markdown
Member

Adds missing typings from #66064 and #66298

Refs: nodejs#66064
Refs: nodejs#66298
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added the typings Issues and PRs related to internal TypeScript declarations. label Sep 26, 2026
@panva
panva requested review from jasnell and mcollina September 26, 2026 19:40
@panva
panva marked this pull request as draft September 26, 2026 21:15

isUtf8(input: ArrayBufferView | ArrayBuffer | SharedArrayBuffer): boolean;
isAscii(input: ArrayBufferView | ArrayBuffer | SharedArrayBuffer): boolean;
isByteString(input: string): boolean;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isByteString(input: string): boolean;
isLatin1(input: string): boolean;

@panva panva closed this Sep 27, 2026
@panva panva mentioned this pull request Sep 27, 2026
@panva
panva deleted the buffer-binding-typings branch September 27, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant