Skip to content

build: enable Perfetto by default - #65794

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:perfetto-sdk
Open

build: enable Perfetto by default#65794
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:perfetto-sdk

Conversation

@aduh95

@aduh95 aduh95 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

@aduh95
build: enable Perfetto by default
38aa4e8 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 4, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Sep 4, 2026
@aduh95

aduh95 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Windows build is failing:

C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(246,16): error : redefinition of 'sockaddr' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(482,8): message : previous definition is here [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(448,5): error : expected identifier [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(211,33): message : expanded from macro 'IPPROTO_ICMP' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(449,5): error : expected identifier [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(212,33): message : expanded from macro 'IPPROTO_IGMP' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(450,5): error : expected identifier [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(213,33): message : expanded from macro 'IPPROTO_GGP' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(457,5): error : expected identifier [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(214,33): message : expanded from macro 'IPPROTO_TCP' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(463,5): error : expected identifier [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(215,33): message : expanded from macro 'IPPROTO_PUP' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(464,5): error : expected identifier [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(216,33): message : expanded from macro 'IPPROTO_UDP' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(465,5): error : expected identifier [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(217,33): message : expanded from macro 'IPPROTO_IDP' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(481,5): error : expected identifier [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(218,33): message : expanded from macro 'IPPROTO_ND' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(491,5): error : expected identifier [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(220,33): message : expanded from macro 'IPPROTO_RAW' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(493,5): error : expected identifier [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(221,33): message : expanded from macro 'IPPROTO_MAX' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
  In file included from C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h:116:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\ws2def.h(644,16): error : redefinition of 'sockaddr_in' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(309,8): message : previous definition is here [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(136,16): error : redefinition of 'fd_set' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(65,16): message : previous definition is here [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(180,8): error : redefinition of 'timeval' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(108,8): message : previous definition is here [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(236,9): error : redefinition of 'hostent' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(164,9): message : previous definition is here [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(249,9): error : redefinition of 'netent' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(177,9): message : previous definition is here [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(256,9): error : redefinition of 'servent' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(184,9): message : previous definition is here [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(268,9): error : redefinition of 'protoent' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(196,9): message : previous definition is here [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
  In file included from sdk\perfetto.cc:77549:
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock2.h(364,16): error : redefinition of 'WSAData' [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\um\winsock.h(319,16): message : previous definition is here [D:\a\node\node\deps\perfetto\perfetto_sdk.vcxproj]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95 @nodejs-github-bot @jasnell @bjohansebas