test: deflake child-process closed channel test - #65770
Open
christianaurichzm wants to merge 1 commit into
Open
Conversation
The second handle is only sent once the first one is acknowledged, by which time the worker may already have exited, so the write can fail with EPIPE. Observed on AIX in the CI reliability report of 2026-09-04. Signed-off-by: Christian Aurich <christian.aurichzm@gmail.com>
nodejs-github-bot
added
needs-ci
panva
approved these changes
Sep 4, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65770 +/- ##
==========================================
+ Coverage 90.05% 90.07% +0.01%
==========================================
Files 754 769 +15
Lines 256378 261316 +4938
Branches 48486 49624 +1138
==========================================
+ Hits 230886 235371 +4485
- Misses 16619 16990 +371
- Partials 8873 8955 +82 🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EPIPEis another expected outcome of the existing race when sending the second handle. The handle can be queued until the previous one is acknowledged, and the worker may exit before the queued write is flushed.Allow
EPIPEalongside the other expected errors so the test does not fail spuriously.Refs: nodejs/reliability#1650