Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/quic/application.cc
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,12 @@ class DefaultApplication final : public Session::Application {

void ResumeStream(stream_id id) override { ScheduleStream(id); }

void StreamWriteShut(stream_id id) override {
if (auto stream = session().FindStream(id)) [[likely]] {
stream->Unschedule();
}
}

void BlockStream(stream_id id) override {
if (auto stream = session().FindStream(id)) [[likely]] {
// Remove the stream from the send queue. It will be re-scheduled
Expand Down
49 changes: 49 additions & 0 deletions test/parallel/test-quic-stream-stop-sending-buffered.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
// Flags: --experimental-quic --no-warnings

// A peer STOP_SENDING must unschedule buffered outbound data.

import { hasQuic, mustCall, skip } from '../common/index.mjs';
import assert from 'node:assert';

if (!hasQuic) {
skip('QUIC is not enabled');
}

const { connect, listen } = await import('../common/quic.mjs');

const serverStreamReady = Promise.withResolvers();
const clientBuffered = Promise.withResolvers();
const serverReset = Promise.withResolvers();

const serverEndpoint = await listen(mustCall((serverSession) => {
serverSession.onstream = mustCall(async (stream) => {
serverStreamReady.resolve();
await clientBuffered.promise;

const closed = assert.rejects(stream.closed, {
code: 'ERR_QUIC_APPLICATION_ERROR',
});
stream.stopSending(1n);
stream.writer.endSync();
await closed;
serverSession.close();
serverReset.resolve();
});
}));

const clientSession = await connect(serverEndpoint.address);
await clientSession.opened;

const stream = await clientSession.createBidirectionalStream();
const clientClosed = stream.closed.catch(() => {});
const writer = stream.writer;
writer.writeSync(new Uint8Array([1]));
await serverStreamReady.promise;

writer.writeSync(new Uint8Array(64 * 1024));
clientBuffered.resolve();

await serverReset.promise;

await Promise.all([clientClosed, clientSession.closed]);
await serverEndpoint.close();
Loading