ffi: validate fast integer argument ranges#64614
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Validate narrow integer and 64-bit BigInt arguments before entering the Fast API trampoline. This prevents out-of-range values from being silently truncated or wrapped and matches the generic FFI path. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol
trivikr
force-pushed
the
ffi-v8-32-bit-int
branch
from
July 20, 2026 06:51
91a79a2 to
40d2aa3
Compare
ShogunPanda
approved these changes
Jul 20, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64614 +/- ##
==========================================
- Coverage 90.14% 90.13% -0.01%
==========================================
Files 741 741
Lines 242076 242134 +58
Branches 45558 45583 +25
==========================================
+ Hits 218216 218258 +42
+ Misses 15385 15379 -6
- Partials 8475 8497 +22
🚀 New features to boost your workflow:
|
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
the
author ready
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64613
Fast FFI calls bypassed the integer range validation performed by the generic FFI path.
Out-of-range
i8,u8,i16, andu16arguments were silently truncated, while out-of-range 64-bit BigInts were wrapped.This change validates affected integer arguments in the existing JavaScript fast-call wrapper before entering the native trampoline. Invalid values now throw
ERR_INVALID_ARG_VALUE, matching the generic path, while valid calls continue to use the Fast API.The fix also covers
bool,char, and unsigned 64-bit arguments, which use the same conversions.Assisted-by: openai:gpt-5.6-sol