http: guard invalid timeout values in checkConnections#64506
Open
efekrskl wants to merge 1 commit into
Open
Conversation
Signed-off-by: Efe Karasakal <hi@efe.dev>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
bjohansebas
reviewed
Jul 14, 2026
Comment on lines
+25
to
+32
| const { signal, status, stderr } = spawnSync( | ||
| process.execPath, | ||
| [__filename, 'child'], | ||
| { encoding: 'utf8' }, | ||
| ); | ||
|
|
||
| assert.strictEqual(signal, null); | ||
| assert.strictEqual(status, 0, stderr); |
Member
There was a problem hiding this comment.
These kinds of tests make me nervous 😅. Do we already have something similar in the repo for HTTP?
Member
Author
There was a problem hiding this comment.
That makes two of us 😅
There are a few, like https://github.com/nodejs/node/blob/83410d6ac84e4e85cc4f385461c4f0716fd1f836/test/abort/test-http-parser-consume.js
bjohansebas
reviewed
Jul 14, 2026
|
|
||
| server.listen(0, '127.0.0.1', () => { | ||
| setTimeout(() => { | ||
| server.close(() => process.exit(0)); |
Member
There was a problem hiding this comment.
Why not just check whether .close() has been called? And that way we avoid the child part
Member
Author
There was a problem hiding this comment.
Because the buggy behaviour crashes the whole process at native level, so the JS assertion wouldn't run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49324