Skip to content

src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning#62795

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Flarna:async_wrap_dcheck
Apr 21, 2026
Merged

src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning#62795
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Flarna:async_wrap_dcheck

Conversation

@Flarna
Copy link
Copy Markdown
Member

@Flarna Flarna commented Apr 17, 2026

Replace emitting of a process warning by a DCHECK because the use after free in http parser is fixed now.

Refs: #61995 (comment)
Refs: #62095

@Flarna
src: use DCHECK in AsyncWrap::MakeCallback instead emiting a warning
da6785c 
Replace emitting of a process warning by a DCHECK because the use after
free in http parser is fixed now.

Refs: nodejs#61995 (comment)
Refs: nodejs#62095
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 17, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (5f02bdb) to head (da6785c).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62795      +/-   ##
==========================================
- Coverage   89.69%   89.68%   -0.02%     
==========================================
  Files         706      706              
  Lines      218270   218270              
  Branches    41781    41778       -3     
==========================================
- Hits       195772   195746      -26     
- Misses      14398    14437      +39     
+ Partials     8100     8087      -13
Files with missing lines Coverage Δ
src/async_wrap.cc 83.28% <ø> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Flarna Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2026
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 19, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72780/

@Flarna Flarna added async_hooks Issues and PRs related to the async hooks subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 20, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 20, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 20, 2026

Commit Queue failed
- Loading data for nodejs/node/pull/62795
✘  Failed to get collaborator info from nodejs/node/README.md
[Error: Couldn't find #### TSC voting members in the README]
https://github.com/nodejs/node/actions/runs/24673051566

@Flarna Flarna added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 21, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2026
@nodejs-github-bot nodejs-github-bot merged commit 53b8d3c into nodejs:main Apr 21, 2026
104 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 21, 2026

Landed in 53b8d3c

@Flarna Flarna deleted the async_wrap_dcheck branch April 21, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Flarna @nodejs-github-bot @addaleax @legendecas