test: add quic teardown lifecycle tests - #62047
Open
mannie-exe wants to merge 1 commit into
Open
Conversation
Adds shared test helpers (checkQuic, defaultCerts, createQuicPair) and 17 subtests covering session close, session destroy, and endpoint close/destroy behavior. session.close() hangs on current main because handle.gracefulClose() never fires kFinishClose back to JS. Tests assert the documented contract and will fail until that is fixed. Refs: nodejs#60122 Refs: nodejs#60309 Refs: nodejs#57119
nodejs-github-bot
added
needs-ci
Author
|
Hey @jasnell would you mind lmk if this looks alright or if I need to make any changes whenever you have time? |
Member
|
I'll take a look first thing tomorrow morning |
Contributor
|
This pull request has been marked as stale due to 90 days of inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/common/quic/helpers.mjs(similar to quic: For streams allow ReadableStream as body #60237):checkQuicdefaultCertscreateQuicPairtest/parallel/test-quic-session-close.mjs: 5 subteststest/parallel/test-quic-session-destroy.mjs: 5 subteststest/parallel/test-quic-endpoint-close.mjs: 7 subtestssession.close()is broken right now;handle.gracefulClose()never fireskFinishCloseback to JS soawait session.closedhangs forever. Tests are written to the documented contract so they'll fail on current main, which is the point.session.destroy()works fine.Refs: #60309, #57119
#60122 covers 2.3.1, 2.3.3, and 1.2