Skip to content

test: isolate configure-nodedir from npm_config_nodedir #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gengjiawen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: isolate configure-nodedir from npm_config_nodedir #3389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions test/test-configure-nodedir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const { describe, it } = require('mocha')
const { describe, it, before, after } = require('mocha')
const assert = require('assert')
const path = require('path')
const os = require('os')
Expand Down Expand Up @@ -56,6 +56,26 @@ function checkTargetPath (target, value) {
}

describe('configure-nodedir', function () {
// CI harnesses such as citgm export npm_config_nodedir, which parseArgv lets
// override --nodedir, so keep it out of these tests
const envKeys = ['npm_config_nodedir', 'npm_package_config_node_gyp_nodedir']
const savedEnv = {}

before(function () {
for (const key of envKeys) {
savedEnv[key] = process.env[key]
delete process.env[key]
}
})

after(function () {
for (const key of envKeys) {
if (savedEnv[key] !== undefined) {
process.env[key] = savedEnv[key]
}
}
})

it('configure nodedir with node-gyp command line', function (done) {
const prog = gyp()
prog.parseArgv(['dummy_prog', 'dummy_script', '--nodedir=' + path.sep + 'usr'])
Expand All @@ -68,7 +88,7 @@ describe('configure-nodedir', function () {
};
assert.fail()
}
configure(prog, [], assert.fail)
configure(prog, []).catch(done)
})

if (process.config.variables.use_prefix_to_find_headers) {
Expand All @@ -85,7 +105,7 @@ describe('configure-nodedir', function () {
};
assert.fail()
}
configure(prog, [], assert.fail)
configure(prog, []).catch(done)
})

it('use-prefix-to-find-headers build time option - no match', function (done) {
Expand All @@ -101,7 +121,7 @@ describe('configure-nodedir', function () {
};
return SPAWN_RESULT(done)
}
configure2(prog, [], assert.fail)
configure2(prog, []).catch(done)
})

it('use-prefix-to-find-headers build time option, target specified', function (done) {
Expand All @@ -117,7 +137,7 @@ describe('configure-nodedir', function () {
};
return SPAWN_RESULT(done)
}
configure(prog, [], assert.fail)
configure(prog, []).catch(done)
})
}
})
Loading